Add vocab terms for status list 2021 #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
requested review from
msporny,
OR13,
selfissued and
awoie
as code owners
|
already in the context, but not the vocab https://github.com/w3c/vc-data-model/blob/main/contexts/credentials/v2#L117 |
brentzundel
approved these changes
Jul 11, 2023
msporny
approved these changes
Jul 11, 2023
There was a problem hiding this comment.
Approving, noting that due to the change suggested by @mprorock that changes the index calculation, that we might need to rename StatusList2021 to StatusList2023. I know that Troy from Gen Digital had concerns about any breaking changes to StatusList2021 and requested that we not use the same type identifier there.
That, however, can be dealt with in a future PR, during CR if necessary (because of the at risk marker we have).
msporny
requested review from
dlongley,
peacekeeper,
iherman,
mprorock,
brentzundel,
Sakurann and
TallTed
iherman
approved these changes
Jul 12, 2023
Co-authored-by: Ted Thibodeau Jr <[email protected]>
brentzundel
approved these changes
Jul 13, 2023
dlongley
approved these changes
Jul 18, 2023
|
Over a week, multiple approvals, changes addressed. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the second part of #1134