Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First pass at updating validation language #1297
First pass at updating validation language #1297
Changes from 5 commits
965fbbc
0817aff
941bda4
bf6fa2c
2843e16
f373e6c
a6032bd
ea5906e
79791d0
0c87ee0
d3568d7
5536809
5d8849b
87a4db3
9234fb4
64b3e57
4831cf8
b983110
d031bdb
856a5c0
357e218
a49142d
cc5cd92
e07bae4
114c452
03c922d
737cdea
491b378
966b275
d4a6ee2
c9c3120
efd3992
56b52a6
6382c0a
aace5b0
9042355
5168ddc
699d594
19fb1e3
a12a5e1
4d77ad0
64a136a
6ac7150
6adb497
6333d44
5b3bb42
6ff22b7
115d44e
c3a3898
aa68ca2
ceb8685
19671d9
31d3481
b9e31f4
124e6b5
9664ed0
061c4cc
119263a
400bcd8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual check is the
id
of thecredentialSubject
is associated, in some way, with the creator of the verifiable presentation. The language here is a bit loose, but that might be ok. I don't have a concrete suggestion that would be easy to read here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"associated, in some way" is not correct.
This particular example is an example of redeeming an alumni discount from a university, in which case arbitrary association is not the business rule. Subject==Holder is.