Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary vocab comments in vocabulary.yml #1361

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

iherman
Copy link
Member

@iherman iherman commented Nov 26, 2023

The changes are handling the discussion in issue #1319

@iherman
Copy link
Member Author

iherman commented Dec 6, 2023

The issue was discussed in a meeting on 2023-12-05

  • no resolutions were taken
View the transcript

1.4. Remove unnecessary vocab comments in vocabulary.yml (pr vc-data-model#1361)

See github pull request vc-data-model#1361.

Brent Zundel: moving to 1361.
… remove comments. nothing but approvals. does what it says.

@brentzundel
Copy link
Member

Only positive reviews, open for over a week, merging.

@brentzundel brentzundel merged commit 7ce47e1 into main Dec 6, 2023
2 checks passed
@msporny msporny deleted the pr-for-1319 branch December 17, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Purely editorial changes to the specification. post-CR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants