Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the vocab diagram #1387

Merged
merged 1 commit into from
Dec 26, 2023
Merged

Updating the vocab diagram #1387

merged 1 commit into from
Dec 26, 2023

Conversation

iherman
Copy link
Member

@iherman iherman commented Dec 16, 2023

This PR completes #1379 (which has been merged) in adding the EnvelopedVerifiableCredential type to the vocabulary diagram.

Additionally, a minor change is in the vocabulary file itself: instead using a local reference entry to the VCDM spec, it now uses the "official" reference to ensure an up-to-date entry.

Because the preview does not properly handle inputs, etc, I will add a copy of the new SVG diagram into my comment below.

This is an editorial change, and not overly important at that, so I did not mark this PR as pre-CR. For consistency's sake it would be better to merge it, though.

@iherman
Copy link
Member Author

iherman commented Dec 16, 2023

Here is the new diagram:

vocabulary

@iherman
Copy link
Member Author

iherman commented Dec 20, 2023

The issue was discussed in a meeting on 2023-12-19

  • no resolutions were taken
View the transcript

2.9. Updating the vocab diagram (pr vc-data-model#1387)

See github pull request vc-data-model#1387.

Brent Zundel: "Updating the vocab diagram". This is from Ivan.
… It's doing what it says.
… Happy for comments.
… I would appreciate review on it.

Manu Sporny: It's a pretty clean update -- not controversial, AFAICT.

Brent Zundel: I expect it to be merged.
… If you can review and approve that would be great, let us know about nits.
… Any comments before next steps?

@brentzundel
Copy link
Member

perhaps a naïve question, but why isn't proof listed as a property of a VerifiableCredential?

@iherman
Copy link
Member Author

iherman commented Dec 21, 2023

@brentzundel

perhaps a naïve question, but why isn't proof listed as a property of a VerifiableCredential?

Because this diagram is showing exclusively the terms defined in the credentials vocabulary. The proof property is defined in the security vocabulary.

There may be issues around this division (see, e.g., my comment elsewhere), but that is not the subject of these changes and this PR.

@msporny
Copy link
Member

msporny commented Dec 26, 2023

Editorial, multiple reviews, no changes requested, no objections, merging.

@msporny msporny merged commit 4ab9f23 into main Dec 26, 2023
2 checks passed
@msporny msporny deleted the 1379-bis-update-diagrams branch December 26, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants