Update transformPattern.js to support "patterns/landmarks" getting built - #382
Merged
Conversation
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
howard-e
requested review from
jongund and
stalgiag
and removed request for
stalgiag
January 21, 2025 22:13
stalgiag
approved these changes
Jan 22, 2025
stalgiag
left a comment
stalgiag
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to relax this requirement for landmarks pages. Thanks Howard!
remibetin
added a commit
that referenced
this pull request
Mar 19, 2025
* Update `APG` to `WAI` pipeline workflows to handle desync issues and better reports on errors (#361) * Fix #219 * Update 'deploy.yml' to use 'w3cgruntbot' as committer * Update 'pr-create.yml' to force a rebase to happen with main in the case generated branch doesn't have relevant changes; additional error handling coverage with 'create-pr' script * For consistency, rename 'create-pr' script to 'pr-create' * Remove unnecessary delete branch action * Infrastructure: Add case to specially handle conflicts in submodule folder to `pr-create.yml` (#373) * Add case to specially handle conflicts in submodule folder * Additional pr-create.yml workflow changes to support submodule conflict resolution (#374) * Infrastructure: Disable git editor during `git rebase --continue` in `pr-create.yml` (#375) * Update transformPattern.js to support "patterns/landmarks" (#382) * Pin ruby 3.3.3 instead of 3.3.x during workflow builds (#384) * chore: Update `main` with latest changes from `aria-practices` * Remove use of ytkey (deprecated) (#370) * Infrastructure: Create `.tracked-html-assets.json` (#388) * Create .tracked-html-assets.json to make it easier to account for html assets which don't match with the expected html assets' naming structure * chore: Update `main` with latest changes from `aria-practices` * chore: Update `main` with latest changes from `aria-practices` * chore: Update `main` with latest changes from `aria-practices` * Update .tracked-html-assets.json (#395) --------- Co-authored-by: w3cgruntbot <w3cgruntbot@users.noreply.github.com> Co-authored-by: Rémi Bétin <github@remibetin.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve w3c/aria-practices#3216 (comment)