-
Notifications
You must be signed in to change notification settings - Fork 284
Typo: Change all instances of dismissable to dismissible #4265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
in Understanding Content on Hover or Focus
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yatil marked as non substantive for IPR from ash-nazg. |
Adding some context: this is for consistency with the normative wording of the SC, which uses "dismissible". In isolation, both spellings are correct AFAIK, but it's worth settling on one. LGTM |
There's also one instance in Line 3460 in 946397c
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to decide what to do with wcag.json
I saw the wcag.json, but I don’t know if it is actually used anywhere. I also don’t know if it is generated from somewhere else and would auto-update. |
I now also changed wcag.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch seems to have more changes than just fixing "dismissible" - I see e.g. the In Brief section being removed, a note being added, and a ul
being changed to an ol
.
https://github.com/w3c/wcag/pull/4265/files?w=1
Perhaps a sync with main had conflicts that were not correctly resolved?
Should I try re-syncing this?
<section id="intent"> | ||
<h2>Intent</h2> | ||
<p>Additional content that appears and disappears in coordination with keyboard focus or pointer hover often leads to accessibility issues. Reasons for such issues include:</p> | ||
<ol> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change to numbered list looks odd ... not sure what other things may have happened here, but that's the one that jumps out at me /cc @kfranqueiro - maybe worth doing a clean re-do of this PR that literally just finds/replaces the words and nothing else (leaving the reformatting for a separate commit or even leaving it as it currently is)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also removes the "In brief" i think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless I'm misreading it, this makes a lot more fundamental changes to the understanding docs than just the find/replace of the word, so blocking this for now until we can have a proper look
@kfranqueiro Try, but if that doesn't solve it I can make a fresh PR with JUST the word changes |
This is a clean redo of #4265 (which seems to have some unforeseen additional changes)
As I was already messing with things, I did go ahead and do a clean redo of this #4292 (tried re-merging main into this one, but it didn't fix the problem) |
In Understanding Content on Hover or Focus