remove noexport for same-origin with ancestors#253
remove noexport for same-origin with ancestors#253timcappalli wants to merge 1 commit intow3c:mainfrom
Conversation
nsatragno
left a comment
There was a problem hiding this comment.
Thank you! I wonder why it was noexport to begin with.
| <h5 id="algorithm-same-origin-with-ancestors" algorithm>Same-Origin with its Ancestors</h5> | ||
|
|
||
| An [=environment settings object=] (|settings|) is <dfn noexport>same-origin with its | ||
| An [=environment settings object=] (|settings|) is <dfn>same-origin with its |
There was a problem hiding this comment.
Optional: Should we scope this definition to environment settings object with a <dfn for="">?
There was a problem hiding this comment.
yes, I agree this should be scoped because it's explicitly comparing environment settings objects.
Also, I wonder if we should actually move this to HTML as it seems generally useful (and they own the definition of environment settings object)? cc @domenic
There was a problem hiding this comment.
This appears to not work for all environment settings objects, as it only works for Window environment settings objects.
We could move this to HTML, which already does similar things in e.g. https://html.spec.whatwg.org/#coop-reporting:inclusive-ancestor-navigables . However we would not apply it to generic environment settings objects (which have a fraught notion of ancestry, given the existence of shared and nested workers). We would apply it to Document objects.
There was a problem hiding this comment.
yeah, that seems better... we might need to actually check if Cred Man is even using these things correctly.
There was a problem hiding this comment.
Sounds good to me. Thanks for chiming in Domenic!
See discussion in w3c/webappsec-credential-management#253.
Allows export of
same-origin with its ancestorswhich is referenced in WebAuthn and will be referenced in the Digital Credentials API.Preview | Diff