Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix regression in definition of beforeunload prompts caused by #1040 / #1518 #1573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix regression in definition of beforeunload prompts caused by #1040 / #1518 #1573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc4d6f1
clarify the bahaviour of beforeunloaded prompts
jtnord Feb 22, 2021
5d22ffa
Fix the incorrect link to navigation
jtnord Feb 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9730,9 +9730,8 @@ <h2>User prompts</h2>

<p><a>User prompts</a> that are spawned
from <a><code>beforeunload</code></a> event handlers,
are <a>dismissed</a> implicitly upon <a>navigation</a>
or <a>close window</a>,
regardless of the defined <a>user prompt handler</a>.
are <a>dismissed</a> implicitly upon a <a data-lt="Navigate To">navigation</a>
Copy link
Author

@jtnord jtnord Feb 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1040 changed Go to Navigate To and broke the link.
#1518 then tried to fix warnings in invalid links but linked to the wrong thing. (navigation being all implicit navigation and not just explicit in Navigate To)

or a <a>close window</a>, regardless of the defined <a>user prompt handler</a>.
Comment on lines +9733 to +9734
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
are <a>dismissed</a> implicitly upon a <a data-lt="Navigate To">navigation</a>
or a <a>close window</a>, regardless of the defined <a>user prompt handler</a>.
are <a>dismissed</a> implicitly upon a WebDriver-initiated <a data-lt="Navigate To">
navigation</a> or <a>close window</a>, regardless of the defined <a>user prompt
handler</a>.

Copy link
Author

@jtnord jtnord Mar 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jgraham I am not sure that this makes clearer, rather the reverse.
Navigate To is a webdriver spec - (it is a POST /session/{session id}/url) so should not be "WebDriver Initiated" - but always initiated by some other code. If some other functionality was linked to "Navigate To" in the spec then this would already be handled by the spec and behaviour - but nothing is linked to this.


<p>A <a>user prompt</a> has an associated <dfn>user prompt message</dfn>
that is the string message shown to the user,
Expand Down