Repository navigation
Conversation
The "overridden reload" concept was part of HTML's document.open() reload override buffer handling, and was never about a forced or cache-bypassing reload. It has since been removed from HTML. Use HTML's "reload" algorithm for the navigable instead, with user navigation involvement "browser UI", which matches what Back and Forward get via "traverse the history by a delta".
Contributor
Author
|
@jgraham and @sadym-chromium could you please review? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Refresh command currently says to
initiate an overridden reloadof the active document, linking to https://html.spec.whatwg.org/multipage/dom.html#an-overridden-reload. That link no longer exists, and the concept never meant what #850 / 4b29ff4 intended (an overridden, or forced, reload): it was part of thedocument.open()/document.write()reload override buffer machinery, where a reload re-navigated to the script-written source instead of fetching from the network. It was removed from HTML together with that machinery.This PR uses HTML's reload algorithm on the current top-level browsing context's navigable instead, with user navigation involvement set to
browser UI. That matches what Back and Forward get viatraverse the history by a delta, and means the reload cannot be canceled through the Navigation APInavigateevent.A note clarifies that this is a normal reload: it does not bypass the HTTP cache, and persisted state such as the scroll position can be restored. Clients that need a cache-bypassing reload can use WebDriver BiDi's
browsingContext.reloadwithignoreCache: true.Current implementation behavior (scroll position after reload, from zcorpan/navigation-api-qa):
location.reload()This difference exists because Firefox currently uses a cache-bypassing reload: https://bugzilla.mozilla.org/show_bug.cgi?id=2088101
This change is
Preview | Diff