Proposal: manifest key trial_tokens#598
Merged
Conversation
patrickkettner
approved these changes
Apr 19, 2024
Contributor
patrickkettner
left a comment
patrickkettner
left a comment
There was a problem hiding this comment.
LGTM, with one nit. I think it would make sense to link to some kind of document about what origin trials are. either on mdn or a chromium explainer or something.
xeenon
reviewed
Apr 19, 2024
xeenon
approved these changes
Apr 19, 2024
dotproto
approved these changes
May 9, 2024
Member
dotproto
left a comment
dotproto
left a comment
There was a problem hiding this comment.
The initial version of this proposal looks solid to me. I'm in favor of merging and iterating on the design as necessary in subsequent PRs as vendors explore implementations.
bershanskiy
force-pushed
the
proposals-manifest-trial_tokens
branch
from
199cf49 to
9f3ce3a
Compare
bershanskiy
force-pushed
the
proposals-manifest-trial_tokens
branch
from
9f3ce3a to
6a7b460
Compare
mukul-p
approved these changes
Jun 6, 2024
zombie
approved these changes
Mar 25, 2025
Collaborator
zombie
left a comment
zombie
left a comment
There was a problem hiding this comment.
This looks good from our side.
oliverdunk
added a commit
to oliverdunk/webextensions
that referenced
this pull request
Mar 26, 2025
Adds information on the `trial_tokens` key to the specification, based on the proposal [1]. The proposal is quite in depth but I have kept the specification more limited as I don't think we neccessarily need to specify each algorithm here. [1] w3c#598
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal formalizes #454 into a concise document.