Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconVariants: Correct spelling & address svg and empty icon_variants #775

Merged
merged 1 commit into from
Mar 25, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions proposals/dark_mode_extension_icons.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ menus.create(menusProperties);
menus.update(id, menusProperties);
```

A benefit of this new structure is that it's more resiliant to future changes,
A benefit of this new structure is that it's more resilient to future changes,
thus allowing for more keys such as density (e.g. 2dppx), purpose (e.g.
monochrome), and etc.

Expand Down Expand Up @@ -166,10 +166,14 @@ effectively have a wild-card for `color_schemes`. For example, `["*"]` is valid.
**Misc**
1. If the top-level `icon_variants` key is provided, the top level `icons` key
will be ignored.
1. `icon_variants` will not cause an error in the event that it is invalid.
1. `icon_variants` will not cause hard errors if no icon groups are found or
specific icon groups have unknown properties. It may cause a hard error if icon
groups are not of type object.
Instead, only the faulty icon group(s) will be ignored, with an optional
warning. Warnings are preferred over errors because they're more adaptable to
changes in the future.
changes in the future. If none of the icon groups are valid, agents can
fallback to the `icons` property in `manifest.json`. If `icons` is
missing, agents are expected not to give a hard error, but can yield a warning.
1. `color-schemes`. Any icon group that does not contain a `color_schemes` key
will apply to all available options, e.g. both "light" and "dark".
1. **Group**. If only one icon group is supplied, it will be used as the
Expand Down
Loading