feat: add support for parsing async iterable<T> type
#775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
saschanaz
reviewed
Mar 26, 2024
| @@ -75,7 +75,9 @@ export class Attribute extends Base { | |||
| yield* this.extAttrs.validate(defs); | |||
| yield* this.idlType.validate(defs); | |||
|
|
|||
| if (["sequence", "record"].includes(this.idlType.generic)) { | |||
| if ( | |||
| ["async iterable", "sequence", "record"].includes(this.idlType.generic) | |||
There was a problem hiding this comment.
It indeed doesn't make sense but the spec PR does not fix https://whatpr.org/webidl/1397/402a886...0402e85.html#idl-attributes "The type of the attribute ..." part.
There was a problem hiding this comment.
The spec PR disallows it outright in any "return to JS position" because it does not define IDL->JS conversion (only JS->IDL).
Should I make this more clear?
There was a problem hiding this comment.
I'd say yes as sequence being attribute is disallowed multiple times in the spec (at the attribute definition and also at the sequence definition).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
async iterable<T>(whatwg/webidl#1397).