Skip to content

Commit

Permalink
Update centrifuge-gsrpc-v2_2_niklabh.md
Browse files Browse the repository at this point in the history
  • Loading branch information
semuelle authored Jun 29, 2023
1 parent a09fbc5 commit 1474659
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion evaluations/centrifuge-gsrpc-v2_2_niklabh.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
| Number | Deliverable | Accepted | Link | Evalulation Notes |
|--------|----------------------------------|-------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------|
| 1. | License | <ul><li>[x] </li> </ul> | [License](https://github.com/centrifuge/go-substrate-rpc-client/blob/event-parsing-v2/LICENSE) | Apache License v2 |
| 2. | Documentation | <ul><li>[x] </li> </ul> | [Documentation](https://github.com/centrifuge/go-substrate-rpc-client/blob/event-parsing-v2/registry/REGISTRY.md) | Documentation Needs to be improved |
| 2. | Documentation | <ul><li>[x] </li> </ul> | [Documentation](https://github.com/centrifuge/go-substrate-rpc-client/blob/event-parsing-v2/registry/REGISTRY.md) | Documentation updated on request |
| 3. | PR with changes | <ul><li>[x] </li> </ul> | [centrifuge/go-substrate-rpc-client#338](https://github.com/centrifuge/go-substrate-rpc-client/pull/338) | PR looks good |
| 4a. | Registry Unit Tests | <ul><li>[x] </li> </ul> | [UnitTest](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/registry_test.go) | Unit Test coverage is good |
| 4b. | Registry (Events) Live Tests | <ul><li>[x] </li> </ul> | [Events Live Tests](https://github.com/centrifuge/go-substrate-rpc-client/blob/20047b8b15d046d0fa137cc716cb489395a0081a/registry/retriever/event_retriever_live_test.go) | Tests are running fine |
Expand Down

0 comments on commit 1474659

Please sign in to comment.