Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ink! analyzer (phase 2) - milestone 3 #1072

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

davidsemakula
Copy link
Contributor

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1904 < please fill this in with the PR number of your application.

@keeganquigley
Copy link
Contributor

@davidsemakula thanks for the delivery! Someone will take a look in the next few days.

@keeganquigley keeganquigley self-assigned this Dec 9, 2023
@davidsemakula
Copy link
Contributor Author

@keeganquigley I updated the recommended tag for testing to a newer release.

@keeganquigley
Copy link
Contributor

keeganquigley commented Dec 14, 2023

Thanks again and sorry for the delay @davidsemakula here is my final evaluation. Everything works as expected. Happy to pass this and congrats on the completion of the grant! This is a great tool!

UPDATE: Whoops I see there are two more milestones. Looking forward to them!

@keeganquigley keeganquigley merged commit 9b8ef78 into w3f:master Dec 14, 2023
3 checks passed
Copy link

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

@davidsemakula
Copy link
Contributor Author

Thanks for the thorough review and positive feedback @keeganquigley 🙂
I've also sent the invoice via the form.

Whoops I see there are two more milestones. Looking forward to them!

There's actually 3 more 🙂, but the next one (milestone 4 - the last one for the semantic analyzer) is the big one (it will implement the remaining new low-level features for this phase/grant). The last 2 after that (milestone 6 & 7 - milestone 5 is already done) simply reuse/consume semantic analyzer features in higher level components (i.e. the language server and VS Code extension) and will be mostly focused on robustness, automated testing and documentation at that point (since a lot of the new semantic analyzer features from milestones 1-3 have already been shipped for the other components at this point). So in reality its indeed very close to completion (at least in terms of features) even if there's technically 3 more milestones to go.

Adoption is also coming along well - at about ~180 unique installs for the VS Code extension 🚀

@davidsemakula davidsemakula deleted the ink-analyzer branch December 26, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants