Deliver DelightfulDOT M1

[sinzii]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1907

[keeganquigley]

Sorry for the delay @sinzii I have started on this today. Should I be using the w3f-delivery/m1 branch for everything or main? Thanks!

[sinzii]

Hi @keeganquigley, please use the branch w3f-delivery/m1 for M1 evaluation. The main branch is now containing commits for M2. Thank you!

[keeganquigley]

Thanks @sinzii much appreciated! Everything is looking great except for a couple of unit tests that are failing:

> @delightfuldot/codecs:test


 RUN  v0.34.6 /Users/keeganquigley/delightfuldot/packages/codecs

 ✓ src/generic/__tests__/Header.spec.ts  (3 tests) 3ms
 ❯ src/registry/__tests__/CodecRegistry.spec.ts  (15 tests | 2 failed) 12ms
   ❯ src/registry/__tests__/CodecRegistry.spec.ts > CodecRegistry > with metadata > findCodec > should supports wrapper type
     → inspect is not a function
   ❯ src/registry/__tests__/CodecRegistry.spec.ts > CodecRegistry > with metadata > findPortableCodec > should find existing codec
     → inspect is not a function
 ✓ src/metadata/__tests__/Metadata.spec.ts  (4 tests) 79ms

⎯⎯⎯⎯⎯⎯⎯ Failed Tests 2 ⎯⎯⎯⎯⎯⎯⎯

 FAIL  src/registry/__tests__/CodecRegistry.spec.ts > CodecRegistry > with metadata > findCodec > should supports wrapper type
TypeError: inspect is not a function
 ❯ Shape._inspect ../../node_modules/subshape/src/common/shape.ts:68:33
 ❯ Shape.[nodejs.util.inspect.custom] ../../node_modules/subshape/src/common/shape.ts:45:17
 ❯ src/registry/__tests__/CodecRegistry.spec.ts:63:21
     61|
     62|       it('should supports wrapper type', () => {
     63|         expect(util.inspect(registry.findCodec('Option<u32>'))).toEqua…
       |                     ^
     64|         expect(util.inspect(registry.findCodec('Vec<u32>'))).toEqual('…
     65|         expect(util.inspect(registry.findCodec('Result<u32, bool>'))).…

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[1/2]⎯

 FAIL  src/registry/__tests__/CodecRegistry.spec.ts > CodecRegistry > with metadata > findPortableCodec > should find existing codec
TypeError: inspect is not a function
 ❯ Shape._inspect ../../node_modules/subshape/src/common/shape.ts:68:33
 ❯ Shape.[nodejs.util.inspect.custom] ../../node_modules/subshape/src/common/shape.ts:45:17
 ❯ src/registry/__tests__/CodecRegistry.spec.ts:96:21
     94|     describe('findPortableCodec', () => {
     95|       it('should find existing codec', () => {
     96|         expect(util.inspect(registry.findPortableCodec(1))).toEqual('$…
       |                     ^
     97|         expect(registry.findPortableCodec(2)).toEqual($.u8);
     98|         expect(registry.findPortableCodec(4)).toEqual($.u32);

⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯⎯[2/2]⎯

 Test Files  1 failed | 2 passed (3)
      Tests  2 failed | 20 passed (22)
   Start at  21:10:18
   Duration  803ms (transform 155ms, setup 0ms, collect 855ms, tests 94ms, environment 590ms, prepare 141ms)


 ————————————————————————————————————————————————————————————————————————————————————————————————————————————————————————

 >  Lerna (powered by Nx)   Running target test for 4 projects failed

   Tasks not run because their dependencies failed or --nx-bail=true:

   - delightfuldot:test

   Failed tasks:

   - @delightfuldot/codecs:test
   - ```

[sinzii]

@keeganquigley Thank you for the feedback. May I ask which OS, Node version that you are using for running tests.

The tests are running fine in my environment (MacOS, Node v18.14.2) and also on GH action (Ubuntu, Node v18.19.0). So this is probably due to some OS or Node version specific issue.

[keeganquigley]

Hi @sinzii thanks I was able to get it running on both Ubuntu and Codespaces, so it must have been an issue with my Mac. I'm happy to pass the milestone, great work! Here is my final evaluation. Everything is working out of the box. Any chance for light clients to be supported in the future?

Looking forward to the next one.

[github-actions]

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we've created a badge for projects that successfully deliver their first milestone. Please use the badge only in reference to the work that has been completed as part of this grant, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant. Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation's guidelines in doing so. If you haven't already, reach out to [email protected] for feedback on your announcement and cross-promotion.

Thank you for your contribution, and good luck! If you have any remaining milestone, let us know if you encounter any delays by leaving a comment on the application PR or submitting an amendment.

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[sinzii]

@keeganquigley Wonderful! Thank you for the evaluation!

Any chance for light clients to be supported in the future?

Definitely, this is on our roadmap for the future!

Please fill out the invoice form in order to initiate the payment process.

I did submit the invoice at the time I created the PR, but I've just resubmitted it again just in case!

[RouvenP]

hi @sinzii we sent the payment today

[sinzii]

@RouvenP Thank you, we've received the fund!