ink! analyzer (phase 2) - milestone 7

[davidsemakula]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, an invoice must be submitted and the payment will be transferred to the Polkadot/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1904 < please fill this in with the PR number of your application.

[keeganquigley]

Thanks for the delivery @davidsemakula please see my evaluation here. It mostly looks great with a couple minor issues.

[davidsemakula]

Hi @keeganquigley
Thanks for the swift review.

I can see the cause of the issues.
The necessary changes are gonna be mostly to instructions (for commands) and improving dependency declarations in Cargo.toml files for the test fixtures a bit (I kinda went bare minimum their initially, just enough for rust-analyzer to not scream too much but I can see how the approach can make testing more confusing).

I'm gonna push some changes and ping you in a bit 🙂

[davidsemakula]

@keeganquigley I've made the following changes.

For the commands, I've updated instructions for running commands to be a bit more clear.

For test-fixtures used in integration tests (especially the one for non-packed-tuple-struct), I've updated the dependencies a bit to at least remove unresolved dependency errors from rust-analyzer while in the editor (you'll need to pull from the master branch to get the latest changes).

Finally, in terms of running automated tests, only the yarn test ones for the actual VS Code extension (run from the project root, not the test-fixtures folder) are relevant in this case. The ink! contracts in the test-fixtures directory are simply copied from https://github.com/paritytech/ink/tree/v4.2.1/integration-tests and are only there to support the integration tests run with yarn test (as well as the manual testing through launch configurations) - this similar to their purpose in the ink! repository as well i.e. "testing specific features, which are distinct from real world examples". So they're not meant to be tested directly with something like cargo test ... because those tests don't really say anything about the functionality of the VS Code extension itself🙂. You can have a look at the inline comments in one of the VS Code integration tests (e.g. https://github.com/ink-analyzer/ink-vscode/blob/master/src/test/suite/actions.test.ts#L16-L43) for some details about how the test-fixtures are used (essentially, the integration tests perform similar actions to the ones described in the manual testing guide to verify that the extension works correctly).

[keeganquigley]

Thanks for the changes @davidsemakula and the explanations are greatly appreciated. Everything works great and I appreciate the great documentation. The tool works seamlessly alongside rust-analyzer and I really hope to see devs start utilizing this, thanks for your hard work! Final evaluation is here. Congrats on the completion of the grant!

[github-actions]

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding and Common Good projects have a good chance of receiving Treasury Funding. If you are looking for guidance, the team at https://substrate.io/ecosystem/square-one/ has compiled a list of ecosystem support sources and are happy to help you navigate it.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

[github-actions]

🪙 Please fill out the invoice form in order to initiate the payment process. Thank you!

[davidsemakula]

Awesome, thanks for the swift and thorough review (as always 🙂) @keeganquigley, and for the positive feedback as well!

As for adoption, the VS Code extension install base is still growing steadily at about ~260 unique installs now (roughly another +40 new unique installs since the last review about ~3 weeks ago) 🚀

[davidsemakula]

I've also submitted the invoice 🙂

[davidsemakula]

Hi @RouvenP
just checking in since it's about 2 weeks now since the approval 🙂

[RouvenP]

hi @davidsemakula we sent it an hour ago :)

[davidsemakula]

@RouvenP received, thanks!