Submit xmc-tools-follow-up m1

[gmajor-encrypt]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, invoices must be submitted and payments will be transferred to the Polkadot AssetHub and/or fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#2205

[PieWol]

Hey @gmajor-encrypt ,
thank you for submitting the delivery. I will notify you once my evaluation is completed.

[PieWol]

Hi @gmajor-encrypt ,
my evaluation is finished with some changes requested. Looking forward to your comments on this and the changes you will make. Please notify me as soon as you have updates to share.

[gmajor-encrypt]

@PieWol Thanks for your evaluation. I will make change as soon.

[gmajor-encrypt]

@PieWol I have update the code. Please check again.

Xcm V3 struct not as strictly typed as the rust implementation

Since xcm-tools does not involve the need to construct xcm messages. Therefore, dynamic types are used here, which are only useful when parse messages.

[PieWol]

Hey @gmajor-encrypt,
thanks for the updates. Changes to the documentation are looking good. Have you made sure that the tests are working? After pulling your changes, building again and starting the tests I have the issue that the tests are still not passing.

Please let me know once you fixed the tests in Docker. I have pulled the changes and re ran the commands to build and test with Docker. If I am missing a step please let me know as well. I have updated my evaluation so it reflects the current issues and testing output.

Thanks :)

[gmajor-encrypt]

@PieWol Thanks for your evaluation. I think the lack of test success in docker is because there is no re-docker build. You can try it after building. docker build -t xcm-tools . && docker run -it --rm xcm-tools

[PieWol]

I'm really confused as I was pretty sure that I have built it again after pulling the latest changes. Yet for some reason after building again it is now working. Thanks for your patience.

I'll have my evaluation updated so that it is now accepted.

[semuelle]

I just merged the evaluation. Your milestone is hereby accepted. Congrats, @gmajor-encrypt.

[RouvenP]

hi @gmajor-encrypt we sent the payment last Friday