SaaS3_Milestone_2

[SaaS3Lab]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#1339.

[SaaS3Lab]

Hey @keeganquigley would u mind to have a look ?

[keeganquigley]

Thanks for the delivery @SaaS3Lab, an evaluator will take a look shortly.

[dsm-w3f]

@SaaS3Lab thank you for the milestone delivery. Please see the evaluation document and provide proper answers and fixes. After that, let me know when I can continue the evaluation.

[songtianyi]

During the execution of the installation steps I had one doubt. Is the Prepare parachain node step needed since the para-2000-genesis-state and para-2000-wasm files are in the repository?

Yes, they are in the repo root directory.

In Register with the local relay chain and in the Prepare parachain node needs to specify that the user needs to access the substrate with port 9977 to do the configuration.

Access the relay chain with port 9944 to do the configuration should be ok for all.

The testing guide needs to have examples of inputs and expected outputs. The frontend also needs a testing guide.

We added some input examples in Tutorial, please check
Check this for frontend testing guide.

Automated Test
I ran cargo test. All tests passed but returned some warnings.

FIXED Please check again

I ran cargo tarpaulin to check the coverage of the tests in the pallets. The coverage can be improved.

The pallet test coverage are 90%+ now

Manual testing
Despite the testing guide doesn't have examples of inputs and expected outputs, I tried to check the pallets and the frontend.
I couldn't figure out what to put in the category_type of Treasury.receive. So I have done the donations using the frontend and could check the transfer to the Treasury in the substrate. I could submit a lawsuit and vote using the frontend and the substrate, but when I tried to process the lawsuit, in the frontend, nothing occurred. In the substrate, I received a BadOrigin message. So I couldn't try to claim the rewards.

category_type is used for categorizing the donation. For testing, any non-zero u32 value can be used.

For now, only the root user can process a lawsuit. In the future, this functionality will be available to all jury members.
Please recheck the tutorial.

Code Quality

We have fixed the winnings in the pallet court and pallet treasury. Actually, we cloned the parachain template from this repo, and most of the warnings come from the original repo.

Yarn lint warnings are fixing

[songtianyi]

@dsm-w3f When the warnings are fixed, we will let you know.

[songtianyi]

@dsm-w3f yarn lint warnings are fixed

[SaaS3Lab]

Hi @dsm-w3f , Can u follow this PR and give us ur feedback ?

[dsm-w3f]

@SaaS3Lab and @songtianyi thank you for the improvements and fixes. I tried again and some parts were improved. I'm having problems with the part that needs a root user for the testing. Could you assist with that? See details in the evaluation document. Let me know when I can continue this evaluation.

[songtianyi]

@SaaS3Lab and @songtianyi thank you for the improvements and fixes. I tried again and some parts were improved. I'm having problems with the part that needs a root user for the testing. Could you assist with that? See details in the evaluation document. Let me know when I can continue this evaluation.

You could try it with your own created account, if some error happens, let me know.

[dsm-w3f]

@songtianyi I tried again but seems that the parachain provided there is no sudo pallet nor a root user specified in the chainspec. I tried to create one based on your plain chainspec but didn't work as well. In the relaychain there is sudo pallet and root user but not in the parachain where we need to make the calls. I suggest taking a look at these links (origins, sudo pallet, chainspec) where I got the information about root users and try to add sudo pallet and generate a parachain with a root user to test the application integrated with polkadot.js. Without that I (and possible users) can't make the privileged calls for some extrinsics using plokadot.js. Let me know when this is available to continue this evaluation.

[songtianyi]

@songtianyi I tried again but seems that the parachain provided there is no sudo pallet nor a root user specified in the chainspec. I tried to create one based on your plain chainspec but didn't work as well. In the relaychain there is sudo pallet and root user but not in the parachain where we need to make the calls. I suggest taking a look at these links (origins, sudo pallet, chainspec) where I got the information about root users and try to add sudo pallet and generate a parachain with a root user to test the application integrated with polkadot.js. Without that I (and possible users) can't make the privileged calls for some extrinsics using plokadot.js. Let me know when this is available to continue this evaluation.

I have changed the permission; please try it again. So sorry for the trouble.

[dsm-w3f]

@songtianyi thank you for the answer and fixes. I tried again using polkadot.js to interact with the pallet and didn't work. I tried it in the unit tests are working. Did you try with polkadot.js? Maybe I'm missing something. Just to know if it is working for you and if any further step is needed to complete these tests. See details in the evaluation document.

[songtianyi]

@songtianyi thank you for the answer and fixes. I tried again using polkadot.js to interact with the pallet and didn't work. I tried it in the unit tests are working. Did you try with polkadot.js? Maybe I'm missing something. Just to know if it is working for you and if any further step is needed to complete these tests. See details in the evaluation document.

Did you try it with our frontend web page?

[dsm-w3f]

@songtianyi I tried and didn't work. I tried again and added some prints to the evaluation document. I think would be nice if you produce a demo video showing the installation process and also the usage of the software. In this way, I can check if there is some step missing and try to reproduce your results.

[songtianyi]

@songtianyi I tried and didn't work. I tried again and added some prints to the evaluation document. I think would be nice if you produce a demo video showing the installation process and also the usage of the software. In this way, I can check if there is some step missing and try to reproduce your results.

OK

[songtianyi]

@dsm-w3f The regenerated wasm file didn't change when I modified the pallet permission check logic code

[songtianyi]

@dsm-w3f
Hi, I have fixed the bad origin problem.
Please update the code source and rebuild it, the chain spec files, the genesis state file, and the wasm file both updated.
Then try it again. I have added some images for demonstration; you can check them in Tutorial.md file

[dsm-w3f]

@songtianyi Thanks for the improvements and fixes. Now I was able to check the functions that failed before, they worked. However, now the automated tests are not passing and I was not able to remove a Sue (removeSue). I don't know if this is in the scope of the grant, but at least the automated tests need to pass. See details in the evaluation document. Let me know when I can continue this evaluation. PS: Next week I'll be out-of-office, so maybe someone take over this evaluation or hope to hear from me after the next week.

[songtianyi]

@dsm-w3f

1. The LICENSE has been added to both repos.
2. The tests are fixed.
3. remove_sue is not part of the scheduled delivery. It works as intended.

[dsm-w3f]

@songtianyi thank you for the improvements and fixes. The tests are passing now and the licenses were added. The milestone is approved. I'll forward your invoice internally and the payment should take place within two weeks. Great Job!

[github-actions]

We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊

So, where to from here? First of all, you should join our Grants Community chat, if you haven't already, so we can stay in touch.
If you are looking for continuative support for your project, there are quite a few options. The main goal of the W3F grants program is to support research as well as early-stage technical projects. If your project still falls under one of those categories, you might want to apply for a follow-up grant. However, depending on your goals and project status, there are other support programs in our ecosystem that might be better suited as the next step. For example, projects with a Business Case/Token should look into the Substrate Builders Program or VC Funding. Common Good projects have a good chance of receiving Treasury Funding.

For a more comprehensive list, see our Alternative Funding page. Let us know if you have any questions regarding the above. We are more than happy to point you to additional resources and help you determine the best course of action.
Lastly, we hope your W3F grant was a success and we want to thank you for being part of the journey!

[fededubbi]

Hi @songtianyi,

I noticed that on the invoice you report an amount in USDT, but the payment address is in USDC.
Can you please update one of these two accordingly?

Many thanks,
Federica

[SaaS3Lab]

Hi @songtianyi,

I noticed that on the invoice you report an amount in USDT, but the payment address is in USDC. Can you please update one of these two accordingly?

Many thanks, Federica

@fededubbi The Invoice has been modifiied from USDT to USDC, pls kindly have a check.

[dsm-w3f]

@SaaS3Lab thanks for updating the invoice. I notice that the payment address is different from the one reported in the grant application. Could you please either update the application by sending an amendment or submit a new invoice with the same payment address from the application?

[SaaS3Lab]

@dsm-w3f We re-submitted the invoice with the same payment addressin application. Actually, it's the same address, only difference is "allow use on any chain" or "Polkadot Rely Chain". Anyway, the address is exact the same as before. Thanks for ur remind.

[fededubbi]

Hi @SaaS3Lab,

We noticed that your supplier name is strange.
Can you please only put 'SaaS3'?

Many thanks,
Federica

[SaaS3Lab]

@fededubbi The supplier name has been modified to "SaaS3" and re-submitted, pls have a check.

[meldien]

@SaaS3Lab Hi everyone, could you please update the USDC to USDT, also the amount should be 5000 USDT instant of 5000 USDC. Many thanks for your support.

[SaaS3Lab]

@SaaS3Lab Hi everyone, could you please update the USDC to USDT, also the amount should be 5000 USDT instant of 5000 USDC. Many thanks for your support.

@meldien The submitted invoice already has been modified as USDC and 5000 USDC. Pls have a check.

[meldien]

@SaaS3Lab Apologies my explanation was not clear.
If the goal would be to pay you in USDC then the invoice is fine, so far your address is correct.
If we have to pay in USDT (Statemint) please update the invoice. The last payment for the Milestone 1 was done in USDT.
Properly that's the reason for my confusion.

[SaaS3Lab]

@meldien Thanks for ur clarification. Although milestone1 payment is USDT. But the payment goal of milestone2 is USDC instead USDT. We want a USDC payment at milestone2.

[fededubbi]

Hi @SaaS3Lab,

We can't pay in USDC on Polkadot, is it okay for you if we pay in USDT?

Many thanks,
Federica

[SaaS3Lab]

Hi @SaaS3Lab,

We can't pay in USDC on Polkadot, is it okay for you if we pay in USDT?

Many thanks, Federica

@fededubbi Of course, we accept USDT payment on Polkadot.

[meldien]

@SaaS3Lab Many thanks for your conformation.
Could you please update your send invoice?
I have to make sure, the payout is matching with the added information on the invoice.

Many thanks, Melanie

[SaaS3Lab]

@meldien Sure. The invoice has been modified from USDC to USDT. Thanks !

[SaaS3Lab]

@meldien Is there any else should be fixed or improved ?

[meldien]

@SaaS3Lab apologies the payout delay. I didn't share the updated invoice in time.
The payout will be done lastet tomorrow. Stay you updated when it's done

[meldien]

@SaaS3Lab transfer done