-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SARP - Milestone 1 Research #880
Conversation
Thank you @masapr for the submission of your research milestone 1. I have started an external evaluation here: #885 Based on my evaluation, you can improve the submitted documentation and engagement. I would like to see more progress in solving the major issues with MIRAI as stated in your Findings and Open Issues 1, 2 before accepting the deliverable. As I understand your granted application, the overall idea was to find if MIRAI is a suitable tool for statically analysing substrate code. By providing more details (with code examples and error outputs) it would be easier to evualuate your findings. I am rejecting the delivery in its current state but will accept the delivery when the points stated in the evaluation are resolved or commented. See the full evaluation in the PR above. If you have any questions or comments ask away. |
@niklasp thanks a lot for your evaluation. We pushed an updated version on the Milestone_Research1 branch. The main points we worked on are:
Apart from that, see my review comments on your PR for further details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission and thanks for updates, @masapr!
I see that you already addressed most of the issues raised by @niklasp. Therefore, I only have one last request: your Documentation
deliverable is specified as, among other things, "describing the approach we plan to implement in milestone 2, incl. its limitations." I see that you added a summary, but what I don't understand is what the implications of your findings are. Is the work you are suggesting doable in a reasonable amount of time? Or does it justify looking into alternative implementations? And are you planning to continue this analysis? It sounds as if your plan for a follow-up grant is to implement this further, so I assume this is something that needs to be dealt with beforehand.
Thanks for your feedback @semuelle After the evaluation I had removed the Next Steps, as it is similar to the Feasibility of Approach. I added it back now. To answer your question: yes, we want to continue, with the steps I described. Overall our impression is, that MIRAI works well with "not-so-complex" code. So, if we manage to separate the substrate macro code from the pallet logic, so that MIRAI only runs on the newly created pallet logic, I'm positive that this should lead to good results. The biggest risk I see, is that we might not find a solution that Parity agrees with resp. that all solutions have too big of an impact on the substrate code base. Apart from that, my idea was to make a cost estimate and formulate a complete proposal on this once we've got the current milestone approved. "Reasonable amount of time" is a vague term, but yes, I believe it's worth it to do this additional step and I believe it can be done in a reasonable amount of time. Let me know, what you think. If you're positive that we get this milestone approved and that there is a good chance we can do a follow-up grant, I'm also happy to specify the next package before getting the approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We noticed that this is the last milestone of your project. Congratulations on completing your grant! 🎊 |
Hi @masapr, I noticed you included on the invoice both USD bank account and USDC. Many thanks, |
Hi @fededubbi Both would be fine. But USD on the bank account would be more convenient for us. Thank you! |
Hi @masapr, I noticed that you put UBS SWIFT code also with USD account, is it correct or is it another bank? Many thanks, |
Hi @fededubbi Yes, that's correct. The account is with UBS. Best |
Hi @fededubbi |
Hi @masapr, The invoice will be paid tomorrow, but since is in USD it will take 2-3 business days for you to see it. Many thanks, |
Milestone Delivery Checklist
Link to the application pull request: w3f/Grants-Program#1706