Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

centrifuge-gsrpc-v2 milestone 2 evaluation #895

Merged
merged 2 commits into from
Jun 28, 2023
Merged

centrifuge-gsrpc-v2 milestone 2 evaluation #895

merged 2 commits into from
Jun 28, 2023

Conversation

niklabh
Copy link
Contributor

@niklabh niklabh commented Jun 26, 2023

Milestone Delivery Checklist

  • The milestone-delivery-template.md has been copied and updated.
  • The invoice form 📝 has been filled out for this milestone.
  • This pull request is being made by the same account as the accepted application.
  • I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
  • In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
  • The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: #890

@niklabh niklabh mentioned this pull request Jun 26, 2023
Merged
6 tasks
mikiquantum
mikiquantum reviewed Jun 26, 2023
View reviewed changes
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@niklabh Thanks for the review.

evaluations/centrifuge-gsrpc-v2_2_niklabh.md Show resolved Hide resolved
evaluations/centrifuge-gsrpc-v2_2_niklabh.md

- Documentation needs to be improved. Basic tutorial on how to parse any substrate event and type using the new version of the library is missing.
- Unit test coverage is good.
- There is an error in running tests in Makefile. I have submitted a [PR](https://github.com/centrifuge/go-substrate-rpc-client/pull/353) to fix the same.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

evaluations/centrifuge-gsrpc-v2_2_niklabh.md Show resolved Hide resolved
@semuelle
Copy link
Member

Thanks for the evaluation, @niklabh. Nice work. I just left a clarifying comment on one of the issues. Anyway, I'll merge the evaluation as it is. Feel free to submit an update when the issues are resolved. Otherwise, we'll take it from here.

@semuelle semuelle merged commit 4555168 into w3f:master Jun 28, 2023
@niklabh
Copy link
Contributor Author

niklabh commented Jun 29, 2023

Updated evaluation: https://github.com/w3f/Grant-Milestone-Delivery/pull/897/files

@RouvenP
Copy link

RouvenP commented Jun 30, 2023

hi @niklabh we just transferred the KSM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semuelle semuelle semuelle left review comments

@mikiquantum mikiquantum mikiquantum left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklabh @semuelle @RouvenP @mikiquantum