Substrate Swift Api milestone 2

[dileping]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• I have disclosed any and all sources of reused code in the submitted repositories and have done my due diligence to meet its license requirements.
• In case of acceptance, the payment will be transferred to the BTC/ETH/fiat account provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/General-Grants-Program#333

[dastansam]

hey @dileping,

here's the external evaluation of your milestone delivery. It looks good in general, with the except of few failing integration tests. Let me know if there is bug in tests or if I am not running them correctly.

[ypopovych]

hey @dileping,

here's the external evaluation of your milestone delivery. It looks good in general, with the except of few failing integration tests. Let me know if there is bug in tests or if I am not running them correctly.

Integration tests need an environment variable TEST_MNEMONIC set with a 12-word mnemonic(one from the test application can be used). Inside our repo, it's set in the GitHub Action as a secret. We will move tests to the local test node for milestone 3, but for now, they are running on the Westend test net.

The simplest way is to run tests from console as TEST_MNEMONIC="<mnemonic-from-testapp>" swift test

[dastansam]

hey @dileping,
here's the external evaluation of your milestone delivery. It looks good in general, with the except of few failing integration tests. Let me know if there is bug in tests or if I am not running them correctly.

Integration tests need an environment variable TEST_MNEMONIC set with a 12-word mnemonic(one from the test application can be used). Inside our repo, it's set in the GitHub Action as a secret. We will move tests to the local test node for milestone 3, but for now, they are running on the Westend test net.

The simplest way is to run tests from console as TEST_MNEMONIC="<mnemonic-from-testapp>" swift test

thank you for swift response! Indeed, integration tests are passing now with a mnemonic from the test app. I think it would be nice if it was documented in the testing guide or in the README. In any case, all issues are addressed and this delivery lgtm

[ypopovych]

hey @dileping,
here's the external evaluation of your milestone delivery. It looks good in general, with the except of few failing integration tests. Let me know if there is bug in tests or if I am not running them correctly.

Integration tests need an environment variable TEST_MNEMONIC set with a 12-word mnemonic(one from the test application can be used). Inside our repo, it's set in the GitHub Action as a secret. We will move tests to the local test node for milestone 3, but for now, they are running on the Westend test net.
The simplest way is to run tests from console as TEST_MNEMONIC="<mnemonic-from-testapp>" swift test

thank you for swift response! Indeed, integration tests are passing now with a mnemonic from the test app. I think it would be nice if it was documented in the testing guide or in the README. In any case, all issues are addressed and this delivery lgtm

Yeah. My bad. I was too focused on the test app and forgot to add instructions on how to run integration tests from the repo

[keeganquigley]

Hi @dileping thanks for the delivery. The external evaluation has been accepted. Before I merge the milestone, can you update this line of your license file to replace the boilerplate brackets with your copyright owner information date, in order to apply the license? Thanks!

[dileping]

Hi @dileping thanks for the delivery. The external evaluation has been accepted. Before I merge the milestone, can you update this line of your license file to replace the boilerplate brackets with your copyright owner information date, in order to apply the license? Thanks!

Hi @keeganquigley, thanks for accepting the milestone! It was a long one :)

Just added a NOTICE file like we did on our other repositories. I think this way it should be even better.

[keeganquigley]

Thanks @dileping happy to accept the milestone. Yes so glad to see it completed!