-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application: Polkadot Runtime Releaser #2373
base: master
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
Signed-off-by: Xavier Lau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AurevoirXavier thanks for the application. We don't offer payments on ETH mainnet anymore, can you change the payment address to accept USDC on Asset Hub instead? Thanks!
Done. :) |
Thanks @AurevoirXavier I will mark the application as ready for review so the committee can comment. In the meantime, one further question: Your previous grant deliveries were highly rated, but the repos appear to be no longer maintained. What assurances can you give us that you will keep improving and maintaining the CLI tool after the grant milestone is complete? Also can you give an update on the status of Subalfred? |
You can verify that I've made significant improvements after the last delivery. At present, the project is not in active development, but all existing features are functioning well, and I personally use it daily. I've also attempted to recommend this useful tool to others, but it seems I'm not getting enough attention. Perhaps a co-promotion would be beneficial. I haven't received enough feedback, and since my focuse move to node/runtime maintenance last year, I haven't came out much new features for Subalfred. Also, I believe one reason is that it's a CLI tool. Many users prefer a straightforward website where they can click a few buttons to achieve their desired results rather than installing a CLI tool. For instance, obtaining a twoxxhash result. I do have plans to apply for a maintenance grant to develop SubalfredV2 and transition it to the web. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. Given your previous work, I'm happy to support it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your answers @AurevoirXavier I'm also happy to approve it.
We recently started doing KYC/KYB for grantees. While waiting for the third approval, could you please go through the verification process for hack-ink? Thanks!
Let me know if you have any issues during the process.
Thank you for the info. As I mentioned in the application README.
hack-ink doesn't really be registered as a real company(in legal). I host all the code source under the hack-ink GitHub organization. So I use it as the Team name. Then my question is what company document show I upload for this? Should I change to a personal KYC and how? |
Hi @AurevoirXavier thanks for the explanation, in that case, you can just do KYC verification. Thanks. |
I can't see the detailed error on my side. And I can't try it again. Should I use a new email address to try?
|
Hi @AurevoirXavier thanks for letting us know, still looking into this. Will let you know when I have an update. |
BTW, I have double identities. I can try using another one. Previously, I used the HongKong identity, which may not be supported. |
Hi @AurevoirXavier sure feel free to try the alternative one if you want, right now the current one is having issues being accepted. |
I attempted to use all my identities, including ID cards and passport. The identity document and selfie are passed. However, it consistently fails at the applicant data stage. I'm unsure of the reason. My legal name on the document is not my English name; it is presented in the local language. Does this have an impact? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @AurevoirXavier the Polkadot Runtime Releaser sounds like a great project. Could you please for the sake of completeness add a Polkadot relay chain address to which you want to receive the vested DOT?
Hi! Does this mean I can only accept vested DOT instead of USDC on AH? |
Hey, no it doesn't mean you can't be paid in USDC at all. In our FAQ you can see that all grants are 50% paid in vested DOT. If thats fine for you it would be great to also tick the box in your application and include the relay chain address. |
Didn't notice that. The last grant I submitted was a year ago. Thanks, added. |
Great, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to approve it.
Hi @AurevoirXavier I just sent you an email regarding KYC. I used the one you provided in your profile, so let me know if you receive it. Thanks! |
Thanks, replied. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this. I've added a couple of suggestions and comments, feel free to check it out.
Polkadot Runtime Releaser aka PRR. | ||
|
||
Since last year, my work is mainly focused on the chain/node maintenance. | ||
Runtime upgrade is grate feature fo Polkadot-SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime upgrade is grate feature fo Polkadot-SDK. | |
Runtime upgrade is a great feature for the Polkadot-SDK. |
- When to notify the community to upgrade the node? | ||
- Collator/Validator nodes should be upgraded first. | ||
- RPC suppliers should be upgraded later. | ||
- I saw some EVM RPCs require the runtime version equals to the node version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I saw some EVM RPCs require the runtime version equals to the node version. | |
- I saw some EVM RPCs require the runtime version to be equal to the node version. |
- Collator/Validator nodes should be upgraded first. | ||
- RPC suppliers should be upgraded later. | ||
- I saw some EVM RPCs require the runtime version equals to the node version. | ||
- How to host a wasm-override repository for community? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- How to host a wasm-override repository for community? | |
- How to host a wasm-override repository for the community? |
PRR will supply these components, which will all be hosted in one repository. | ||
- A GitHub Action to response the try-runtime. (Users can comment something like `/bot try-runtime <network>` under a release PR to trigger this action.) | ||
- A GitHub Action to build the release runtime. | ||
- A GitHub Action to notify release repository there is a new release that release repository can start preparing the override WASMs. | ||
- A GitHub Action and a tool to monitor the on-chain runtime version and compare it with the release runtime version to trigger the release on the release repository. | ||
- A tool to build and manage the override WASMs. | ||
|
||
Each component will have a very detailed guide to help the chain team to set up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you structure this a bit better, so it's apparent which actions will be supported and what kind of use case they will cover?
For example:
GitHub Action | Trigger | Specification |
---|---|---|
try-runtime |
by commenting /bot try-runtime <network> on the PR |
when executed, XYZ will happen |
| 0c. | Testing guide | There will be a guide and a demo repository to tell the auditor how to run the tests. All components will be covered. | | ||
| 1. | Try-runtime CI | Comment on a release PR and see the try-runtime result. | | ||
| 2. | Release CI | Build and release the deterministic runtimes and the node files. | | ||
| 3. | WASM override tool | It can build the specify feature WASM in one step and manage them well in the corresponding folder. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can build the specify feature WASM
Could you ellaborate on that?
manage them well in the corresponding folder.
Does that mean that the build will be stored on the github repo?
| 1. | Try-runtime CI | Comment on a release PR and see the try-runtime result. | | ||
| 2. | Release CI | Build and release the deterministic runtimes and the node files. | | ||
| 3. | WASM override tool | It can build the specify feature WASM in one step and manage them well in the corresponding folder. | | ||
| 4. | WASM override CI | Listen the build request from release CI. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 4. | WASM override CI | Listen the build request from release CI. | | |
| 4. | WASM override CI | Listen for build requests from the release CI. | |
pinging @AurevoirXavier |
Closed as per discussions in private email thread. |
Re-opening per private email thread 😀 @AurevoirXavier can you address the above open comments? Thanks! |
Absolutely! |
Are you still working on the changes and answers to the comments above, @AurevoirXavier? |
I was struggling with the KYC few days ago. And I'm off work these two days. I'll finish this tomorrow. Sorry for the delay. |
Project Abstract
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)