Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application: Polkadot Runtime Releaser #2373

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AurevoirXavier
Copy link
Contributor

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
  • I understand that an agreed upon percentage of each milestone will be paid in vested DOT, to the Polkadot address listed in the application.
  • I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

Copy link
Contributor

github-actions bot commented Aug 21, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Aug 21, 2024
@AurevoirXavier
Copy link
Contributor Author

I have read and hereby sign the Contributor License Agreement.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AurevoirXavier thanks for the application. We don't offer payments on ETH mainnet anymore, can you change the payment address to accept USDC on Asset Hub instead? Thanks!

@keeganquigley keeganquigley self-assigned this Aug 27, 2024
@keeganquigley keeganquigley added the changes requested The team needs to clarify a few things first. label Aug 27, 2024
@AurevoirXavier
Copy link
Contributor Author

Hi @AurevoirXavier thanks for the application. We don't offer payments on ETH mainnet anymore, can you change the payment address to accept USDC on Asset Hub instead? Thanks!

Done. :)

@keeganquigley
Copy link
Contributor

Thanks @AurevoirXavier I will mark the application as ready for review so the committee can comment. In the meantime, one further question:

Your previous grant deliveries were highly rated, but the repos appear to be no longer maintained. What assurances can you give us that you will keep improving and maintaining the CLI tool after the grant milestone is complete? Also can you give an update on the status of Subalfred?

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Aug 28, 2024
@AurevoirXavier
Copy link
Contributor Author

AurevoirXavier commented Aug 29, 2024

Your previous grant deliveries were highly rated, but the repos appear to be no longer maintained. What assurances can you give us that you will keep improving and maintaining the CLI tool after the grant milestone is complete? Also can you give an update on the status of Subalfred?

You can verify that I've made significant improvements after the last delivery. At present, the project is not in active development, but all existing features are functioning well, and I personally use it daily. I've also attempted to recommend this useful tool to others, but it seems I'm not getting enough attention. Perhaps a co-promotion would be beneficial. I haven't received enough feedback, and since my focuse move to node/runtime maintenance last year, I haven't came out much new features for Subalfred.

Also, I believe one reason is that it's a CLI tool. Many users prefer a straightforward website where they can click a few buttons to achieve their desired results rather than installing a CLI tool. For instance, obtaining a twoxxhash result. I do have plans to apply for a maintenance grant to develop SubalfredV2 and transition it to the web.

Noc2
Noc2 previously approved these changes Aug 29, 2024
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. Given your previous work, I'm happy to support it.

keeganquigley
keeganquigley previously approved these changes Aug 29, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your answers @AurevoirXavier I'm also happy to approve it.

We recently started doing KYC/KYB for grantees. While waiting for the third approval, could you please go through the verification process for hack-ink? Thanks!

Let me know if you have any issues during the process.

@AurevoirXavier
Copy link
Contributor Author

Let me know if you have any issues during the process.

Thank you for the info.

As I mentioned in the application README.

### Legal Structure

Personal. (no legal structure entry)

hack-ink doesn't really be registered as a real company(in legal). I host all the code source under the hack-ink GitHub organization. So I use it as the Team name.

Then my question is what company document show I upload for this? Should I change to a personal KYC and how?

@keeganquigley
Copy link
Contributor

Hi @AurevoirXavier thanks for the explanation, in that case, you can just do KYC verification. Thanks.

@AurevoirXavier
Copy link
Contributor Author

AurevoirXavier commented Sep 1, 2024

Hi @AurevoirXavier thanks for the explanation, in that case, you can just do KYC verification. Thanks.

I can't see the detailed error on my side. And I can't try it again. Should I use a new email address to try?

Unfortunately, we couldn't verify your identity
We could not verify your profile. If you have any questions, please contact the Company where you try to verify your profile

@keeganquigley
Copy link
Contributor

Hi @AurevoirXavier thanks for letting us know, still looking into this. Will let you know when I have an update.

@AurevoirXavier
Copy link
Contributor Author

Hi @AurevoirXavier thanks for letting us know, still looking into this. Will let you know when I have an update.

BTW, I have double identities. I can try using another one. Previously, I used the HongKong identity, which may not be supported.

@keeganquigley
Copy link
Contributor

Hi @AurevoirXavier sure feel free to try the alternative one if you want, right now the current one is having issues being accepted.

@AurevoirXavier
Copy link
Contributor Author

Hi @AurevoirXavier sure feel free to try the alternative one if you want, right now the current one is having issues being accepted.

image

I attempted to use all my identities, including ID cards and passport. The identity document and selfie are passed. However, it consistently fails at the applicant data stage. I'm unsure of the reason. My legal name on the document is not my English name; it is presented in the local language. Does this have an impact?

image

Copy link
Member

@PieWol PieWol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AurevoirXavier the Polkadot Runtime Releaser sounds like a great project. Could you please for the sake of completeness add a Polkadot relay chain address to which you want to receive the vested DOT?

@AurevoirXavier
Copy link
Contributor Author

Hey @AurevoirXavier the Polkadot Runtime Releaser sounds like a great project. Could you please for the sake of completeness add a Polkadot relay chain address to which you want to receive the vested DOT?

Hi! Does this mean I can only accept vested DOT instead of USDC on AH?

@PieWol
Copy link
Member

PieWol commented Sep 10, 2024

Hey, no it doesn't mean you can't be paid in USDC at all. In our FAQ you can see that all grants are 50% paid in vested DOT. If thats fine for you it would be great to also tick the box in your application and include the relay chain address.

@AurevoirXavier
Copy link
Contributor Author

Hey, no it doesn't mean you can't be paid in USDC at all. In our FAQ you can see that all grants are 50% paid in vested DOT. If thats fine for you it would be great to also tick the box in your application and include the relay chain address.

Didn't notice that. The last grant I submitted was a year ago.

Thanks, added.

@PieWol
Copy link
Member

PieWol commented Sep 10, 2024

Great, thanks.

Copy link
Member

@PieWol PieWol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to approve it.

@keeganquigley
Copy link
Contributor

keeganquigley commented Sep 11, 2024

Hi @AurevoirXavier I just sent you an email regarding KYC. I used the one you provided in your profile, so let me know if you receive it. Thanks!

@AurevoirXavier
Copy link
Contributor Author

Hi @AurevoirXavier I just sent you an email regarding KYC. I used the one you provided in your profile, so let me know if you receive it. Thanks!

Thanks, replied.

@takahser takahser self-requested a review September 24, 2024 01:21
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AurevoirXavier

Thanks for submitting this. I've added a couple of suggestions and comments, feel free to check it out.

Polkadot Runtime Releaser aka PRR.

Since last year, my work is mainly focused on the chain/node maintenance.
Runtime upgrade is grate feature fo Polkadot-SDK.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Runtime upgrade is grate feature fo Polkadot-SDK.
Runtime upgrade is a great feature for the Polkadot-SDK.

- When to notify the community to upgrade the node?
- Collator/Validator nodes should be upgraded first.
- RPC suppliers should be upgraded later.
- I saw some EVM RPCs require the runtime version equals to the node version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- I saw some EVM RPCs require the runtime version equals to the node version.
- I saw some EVM RPCs require the runtime version to be equal to the node version.

- Collator/Validator nodes should be upgraded first.
- RPC suppliers should be upgraded later.
- I saw some EVM RPCs require the runtime version equals to the node version.
- How to host a wasm-override repository for community?
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- How to host a wasm-override repository for community?
- How to host a wasm-override repository for the community?

Comment on lines +59 to +66
PRR will supply these components, which will all be hosted in one repository.
- A GitHub Action to response the try-runtime. (Users can comment something like `/bot try-runtime <network>` under a release PR to trigger this action.)
- A GitHub Action to build the release runtime.
- A GitHub Action to notify release repository there is a new release that release repository can start preparing the override WASMs.
- A GitHub Action and a tool to monitor the on-chain runtime version and compare it with the release runtime version to trigger the release on the release repository.
- A tool to build and manage the override WASMs.

Each component will have a very detailed guide to help the chain team to set up.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you structure this a bit better, so it's apparent which actions will be supported and what kind of use case they will cover?

For example:

GitHub Action Trigger Specification
try-runtime by commenting /bot try-runtime <network> on the PR when executed, XYZ will happen

| 0c. | Testing guide | There will be a guide and a demo repository to tell the auditor how to run the tests. All components will be covered. |
| 1. | Try-runtime CI | Comment on a release PR and see the try-runtime result. |
| 2. | Release CI | Build and release the deterministic runtimes and the node files. |
| 3. | WASM override tool | It can build the specify feature WASM in one step and manage them well in the corresponding folder. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can build the specify feature WASM

Could you ellaborate on that?

manage them well in the corresponding folder.

Does that mean that the build will be stored on the github repo?

| 1. | Try-runtime CI | Comment on a release PR and see the try-runtime result. |
| 2. | Release CI | Build and release the deterministic runtimes and the node files. |
| 3. | WASM override tool | It can build the specify feature WASM in one step and manage them well in the corresponding folder. |
| 4. | WASM override CI | Listen the build request from release CI. |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| 4. | WASM override CI | Listen the build request from release CI. |
| 4. | WASM override CI | Listen for build requests from the release CI. |

@semuelle
Copy link
Member

semuelle commented Oct 2, 2024

pinging @AurevoirXavier

@keeganquigley
Copy link
Contributor

Closed as per discussions in private email thread.

@keeganquigley
Copy link
Contributor

Re-opening per private email thread 😀

@AurevoirXavier can you address the above open comments? Thanks!

@keeganquigley keeganquigley reopened this Oct 2, 2024
@keeganquigley keeganquigley removed the admin-review This application requires a review from an admin. label Oct 2, 2024
@AurevoirXavier
Copy link
Contributor Author

@AurevoirXavier can you address the above open comments? Thanks!

Absolutely!

@semuelle
Copy link
Member

semuelle commented Oct 7, 2024

Are you still working on the changes and answers to the comments above, @AurevoirXavier?

@AurevoirXavier
Copy link
Contributor Author

AurevoirXavier commented Oct 7, 2024

Are you still working on the changes and answers to the comments above, @AurevoirXavier?

I was struggling with the KYC few days ago. And I'm off work these two days. I'll finish this tomorrow. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants