Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centrifuge gsrpc v2 #1281

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Centrifuge gsrpc v2 #1281

merged 4 commits into from
Nov 23, 2022

Conversation

mikiquantum
Copy link
Contributor

@mikiquantum mikiquantum commented Nov 17, 2022

Project Abstract

Initially Go-Substrate-RPC (GSRPC for short) was designed under the premise of being a low-level, static and strongly typed library, where all the type resolution happen at compilation time. This approach allowed almost full flexibility to developers to build their own types and events depending on the target chain/s they were connecting to.

On the other hand, since the types are statically defined, this didn’t leave room to, gracefully, deal with parsing errors when a type (defined on the chain runtime) is not defined in the GSRPC client.

More details in the application commit.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@CLAassistant
Copy link

CLAassistant commented Nov 17, 2022

CLA assistant check
All committers have signed the CLA.

@Noc2 Noc2 self-assigned this Nov 18, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application. In general, this is definitely something that we want to support. However, could you structure the milestones as shown in our template, here: https://github.com/w3f/Grants-Program/blob/master/applications/application-template.md#milestone-1-example--basic-functionality? The default deliverables 0a-0d below are usually mandatory for all milestones. This helps us with the evaluations and is also part of the terms and conditions. Regarding the maintenance part, ideally, we would keep this separate. Also, our legal team said that for now, we should sign regular contracts for this. So could you remove this initially?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Nov 18, 2022
@mikiquantum
Copy link
Contributor Author

Hi @Noc2, thanks for the feedback. I just pushed the changes suggested. Let me know if anything else is needed.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update. I’m happy to support it and share it with the rest of the team. I personally think the price is relatively high, but given that you already put so much effort into it and also maintained it in the past without any support from us, I’m happy to support it.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Nov 21, 2022
@dsm-w3f dsm-w3f self-requested a review November 21, 2022 18:35
@dsm-w3f
Copy link
Contributor

dsm-w3f commented Nov 21, 2022

@mikiquantum thank you for your application. As David said, this is definitely something that we want to support. Just for understanding, why did you pick this specific demand as a new grant proposal since seems that you have many other community demands on the GitHub issues from the project? Is this the best demand to work for now? I think is great to have many demands regarding this project since showing us that is being actually used by the community. I also notice that you are working on that demands as far as possible.

@mikiquantum
Copy link
Contributor Author

@dsm-w3f This issue, in a different flavor, has been open for a while centrifuge/go-substrate-rpc-client#220 and indirectly would fix most of the other ones open that are mainly about custom type parsing.
The impact of a successful implementation of this proposal would incur on significant less issues regarding types and parsing.
We believe that this is a key improvement on the usability and maintenance of the library.

Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation @mikiquantum, I'm quite familiar with team's reputation and am happy to support it as well.

@Noc2 Noc2 merged commit 6c3f27a into w3f:master Nov 23, 2022
@github-actions
Copy link
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at [email protected] and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@mikiquantum
Copy link
Contributor Author

Thank you all for the support!

@keeganquigley
Copy link
Contributor

Hi @mikiquantum how is milestone 2 coming along?

@mikiquantum
Copy link
Contributor Author

@keeganquigley We just merged the v2 work . We will open the deliverable asap.

@mikiquantum
Copy link
Contributor Author

@keeganquigley We just opened the Milestone 2 Delivery: w3f/Grant-Milestone-Delivery#890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants