xNFT updates #1889
Closed
xNFT updates #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Noc2
requested changes
Aug 4, 2023
There was a problem hiding this comment.
Thanks for your interest in the grants program. But this doesn't look like an amendment to me, but rather like a new grant application, correct? In this case, could you also fill out this template: #1888 (comment) as part of the PR? If it's actually an amendment, could you instead update the original application and not add a new file to the repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to amend the deliverables for xNFT pallet grant. We have replaced two functions namely transferSingleWithFee and transferMultiWithFee functions with transferCollection and transferCollectionOwnership functions.
The transferCollection function will be used to transfer collection from one chain to another.
While the transferCollectionOwnership will transfer the ownership of a collection across chains.
The reason behind this being: the instructions of xcm which we are using to transfer nfts is transact so for now we don't have any requirements related to fees.
Some instructions of xcm like buy execution requires fee parameter, but we aren't using any such instructions in our pallet.
Also, added names of two team members.