Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rfp/security marketplace #1901

Merged
merged 16 commits into from
Aug 30, 2023
Merged

Conversation

ParthChaudhary31
Copy link
Contributor

@ParthChaudhary31 ParthChaudhary31 commented Aug 10, 2023

Project Abstract

Please replace these instructions with a brief description of your project summarising key points (1-2 paragraphs).

If your application is a follow-up to a previous grant, please mention which one in the first line of the abstract and include a link to previous pull requests if applicable.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
All committers have signed the CLA.

@ParthChaudhary31 ParthChaudhary31 mentioned this pull request Aug 11, 2023
10 tasks
@keeganquigley keeganquigley self-assigned this Aug 11, 2023
@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. labels Aug 11, 2023
@keeganquigley
Copy link
Contributor

Thanks @ParthChaudhary31 you mentioned that this would help save on development costs, does this mean there should be an adjustment in price as well? Or are these only contract deployment costs that aren't covered as part of the grant?

@ParthChaudhary31
Copy link
Contributor Author

ParthChaudhary31 commented Aug 14, 2023

Thanks @ParthChaudhary31 you mentioned that this would help save on development costs, does this mean there should be an adjustment in price as well? Or are these only contract deployment costs that aren't covered as part of the grant?

The latter actually, The cost-cutting would be on the front of :

  1. Deployment costs (Contract optimization by merging functionality into a single contract would require deploying fewer contracts).
  2. The Arbiters will not need to spend from their own pockets while voting. (Minimising gas fees Charges).

keeganquigley
keeganquigley previously approved these changes Aug 14, 2023
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying @ParthChaudhary31 LGTM

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployment costs (Contract optimization by merging functionality into a single contract would require deploying fewer contracts).
The Arbiters will not need to spend from their own pockets while voting. (Minimising gas fees Charges).

I think that (a) deployment costs are negligible as this is a small, one-off fee; (b) combining the contracts makes them less general and reusable, and (c) having an on-chain record of arbiters' voting would make the whole system more trustworthy. The cost of voting is also rather small and there are other ways this could be limited, e.g. by fee-less transactions or a reward pool.

(a) and (b) aren't showstoppers, but I'd be in favor of keeping a trace of the arbiters' votes on-chain.

@ParthChaudhary31
Copy link
Contributor Author

@semuelle ,
I understand your motives for keeping the Arbiter voting on-chain, The change is a suggestion that we believe would smoothen the onboarding process and encourage arbiters, however, we're perfectly fine with keeping it on-chain as well. If you can verify with the remaining team and give a final verdict on the changes, We'll be able to plan accordingly and start with the development.

semuelle

This comment was marked as outdated.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ParthChaudhary31. Sounds good to me. Could you integrate this into the document? I will ping the rest of the committee again.

@github-actions

This comment was marked as duplicate.

@ParthChaudhary31
Copy link
Contributor Author

@semuelle
Sure, I've re-added the Arbiter's voting contract to milestone 1, We'll start working on it now and aim to finish this soon.

Co-authored-by: Sebastian Müller <[email protected]>
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Noc2 Noc2 merged commit 0ffb1a4 into w3f:master Aug 30, 2023
6 of 7 checks passed
ainhoa-a pushed a commit to ainhoa-a/Grants-Program that referenced this pull request Jan 26, 2024
* RFP/security

* changes

* Tables Updated

* Links Updated

* changes

* WireFrames

* MIlestones

* Milestone

* Techstack Added

* Revised Price

* Update applications/Security_Marketplace.md

Co-authored-by: S E R A Y A <[email protected]>

* Updated Security Marketplace

* RFP amendment

* Voting system Pushed On-Chain

Co-authored-by: Sebastian Müller <[email protected]>

---------

Co-authored-by: S E R A Y A <[email protected]>
Co-authored-by: Sebastian Müller <[email protected]>
taqtiqa-mark pushed a commit to taqtiqa-mark/Grants-Program that referenced this pull request Jun 6, 2024
* RFP/security

* changes

* Tables Updated

* Links Updated

* changes

* WireFrames

* MIlestones

* Milestone

* Techstack Added

* Revised Price

* Update applications/Security_Marketplace.md

Co-authored-by: S E R A Y A <[email protected]>

* Updated Security Marketplace

* RFP amendment

* Voting system Pushed On-Chain

Co-authored-by: Sebastian Müller <[email protected]>

---------

Co-authored-by: S E R A Y A <[email protected]>
Co-authored-by: Sebastian Müller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants