Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application :Dfinnwallet #2269

Closed
wants to merge 5 commits into from
Closed

Conversation

Bharathcoorg
Copy link

@Bharathcoorg Bharathcoorg commented Mar 30, 2024

Project Abstract

DFINN Wallet is a comprehensive non-custodial solution for Substrate and EVM Blockchains, leveraging Polkadot.js capabilities. With a focus on enhancing user experience and refining the interface, our wallet serves as a gateway to the Web3 multiverse, providing easy access to multi-chain services while prioritizing security and user convenience. Our purpose-built Mobile App, available on Android and iOS, facilitates seamless interaction with blockchain applications, offering users a frictionless journey into the world of decentralized finance.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (Polkadot AssetHub (DOT, USDC & USDT) address in the application and bank details via email, if applicable).
  • I understand that 30% of each milestone will be paid in vested DOT, to the Polkadot AssetHub address listed in the application.
  • I am aware that, in order to receive a grant, I (and the entity I represent) have to successfully complete a KYC/KYB check.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @bharathcoorg:matrix.org (change the homeserver if you use a different one)

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label Mar 30, 2024
Copy link
Contributor

github-actions bot commented Mar 30, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@Bharathcoorg Bharathcoorg changed the title new application Application :Dfinnwallet Mar 30, 2024
@Bharathcoorg
Copy link
Author

I have read and hereby sign the Contributor License Agreement.

@keeganquigley keeganquigley self-assigned this Apr 2, 2024
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bharathcoorg thanks for the application.

  • You mention "Substrate & EVM chains" I'm not sure if this means you intend to have compatibility for both WASM & EVM (similar to Talisman), or do you only intend to support the EVM chains built with substrate, such as Moonbeam and Astar?
  • What advantages would this wallet have over the existing ones you mentioned (SubWallet, Nova, etc.) and why do you want to build one from the ground up?
  • The grants program doesn't cover 3rd party audits, therefore could you remove milestone 2 and adjust the cost accordingly? That should drop you down to a level 1 grant which only needs two approvals.

@keeganquigley keeganquigley added the changes requested The team needs to clarify a few things first. label Apr 2, 2024
@Bharathcoorg
Copy link
Author

Bharathcoorg commented Apr 3, 2024

  • You mention "Substrate & EVM chains" I'm not sure if this means you intend to have compatibility for both WASM & EVM (similar to Talisman), or do you only intend to support the EVM chains built with substrate, such as Moonbeam and Astar?
    Dfinn wallet supports all substrate and all EVM blockchains. Not only Substrate EVM chains.
  • What advantages would this wallet have over the existing ones you mentioned (SubWallet, Nova, etc.) and why do you want to build one from the ground up?
    At dfinnwallet, we're dedicated to creating new and innovative features that make our wallet stand out from the rest. Our aim is to introduce functionalities that are unique and not commonly found in other wallet solutions. In the current milestone, we've included at least 3–6 features that you won't find in other wallets. The live version of our app is already available on the App Store and Play Store.
    I didn't mention some features I have in mind, such as the interact and earn platform and the AI dapp security scanner. I'll need to conduct thorough research on these features. I'll provide more details about these features in future milestones if needed.
  • The grants program doesn't cover 3rd party audits, therefore could you remove milestone 2 and adjust the cost accordingly? That should drop you down to a level 1 grant which only needs two approvals.
    Removed milestone 2 and downgraded to Level 1.

@keeganquigley
Copy link
Contributor

Thanks for explaining @Bharathcoorg a couple more questions:

  • Is the wallet still fully open-source?
  • What parachains would you aim to support right out of the gate?
  • Also, looking at your wallet now on iOS I see it already has support for Polkadot & Kusama. So just to make sure I understand correctly, this grant is for the extra features which haven't been implemented yet?

@Bharathcoorg
Copy link
Author

  • Is the wallet still fully open-source?
  • What parachains would you aim to support right out of the gate?
  • Also, looking at your wallet now on iOS I see it already has support for Polkadot & Kusama. So just to make sure I understand correctly, this grant is for the extra features which haven't been implemented yet?

I can make it open-source with a new repo, but without cloud wallet features (I want to add this in the next 4-5 months). Currently, our repository is not properly maintained; we started it using Subwallet's code, and we use most of their packages for the basic functions. For the dapps list, we are using Nova Wallet's list. 

We are using Subwallet's chain list and our own list; it supports all parachains, and new parachains can be added easily. You can check the settings for supported networks in iOS. The Android version has more networks right now. 

Yes, this grant is only for implementing new features and starting dfinnwallet as a new project.

@keeganquigley
Copy link
Contributor

Thanks for confirming @Bharathcoorg see our guidelines in regard to our open-source policy. Apart from this my other concern is that these deliverables are primarily only beneficial for your product and won't be widely re-usable for others.

That being said, I will go ahead open it up for the rest of the committee to comment.

@keeganquigley keeganquigley added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Apr 3, 2024
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application and all the effort that you put into this. However, the committee decided that we won't support additional wallets at this stage. There are already a lot of open-source alternatives and if you want to create a new solution you should try to find other funding sources (e.g. VCs) and create a long business model around it.

@Noc2
Copy link
Collaborator

Noc2 commented Apr 4, 2024

(see above)

@Noc2 Noc2 closed this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin-review This application requires a review from an admin. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants