Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendment for Hyperfridge Milestone 4 #2307

Merged
merged 1 commit into from
May 21, 2024

Conversation

dastansam
Copy link
Contributor

This change falls in line with the future goals of the project and will serve as a PoC. More context here

@github-actions github-actions bot added the admin-review This application requires a review from an admin. label May 21, 2024
@PieWol
Copy link
Member

PieWol commented May 21, 2024

Hey @dastansam , thanks for the amendment PR. Is it correct that you are basically going from a solo-chain approach where the stablecoin would be implemented within your chain you are now switching to a parachain approach for the logic of your fiat bridge with the actual stablecoin asset living on AssetHub? Just to make sure I'm understanding this correctly.

@dastansam
Copy link
Contributor Author

Hey @dastansam , thanks for the amendment PR. Is it correct that you are basically going from a solo-chain approach where the stablecoin would be implemented within your chain you are not switching to a parachain approach for the logic of your fiat bridge with the actual stablecoin asset living on AssetHub? Just to make sure I'm understanding this correctly.

yes, stablecoin will be issued/burned in AssetHub and that asset will be controlled by the sovereign account of the parachain.

@PieWol PieWol added the ready for review The project is ready to be reviewed by the committee members. label May 21, 2024
Copy link
Member

@PieWol PieWol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The AssetHub integration via XCM is nice.

@PieWol PieWol self-assigned this May 21, 2024
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PieWol
Copy link
Member

PieWol commented May 21, 2024

Hey @wstrametz , you were the author of the application PR. Please indicate that you want to do this amendment. We need some kind of confirmation that these changes are on your behalf. So please if possible do these PRs from your account or at least post a statement that this is on your behalf. Otherwise this gets confusing.

@keeganquigley keeganquigley added amendment This PR proposes changes to an existing application. and removed admin-review This application requires a review from an admin. labels May 21, 2024
@wstrametz
Copy link
Contributor

Hey @wstrametz , you were the author of the application PR. Please indicate that you want to do this amendment. We need some kind of confirmation that these changes are on your behalf. So please if possible do these PRs from your account or at least post a statement that this is on your behalf. Otherwise this gets confusing.

Hi - @PieWol - yes confirm that its on my behalf. Thx a lot, Walter

@Noc2 Noc2 merged commit 3dd341c into w3f:master May 21, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants