Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo office hours #2327

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Redo office hours #2327

merged 1 commit into from
Jun 7, 2024

Conversation

semuelle
Copy link
Member

@semuelle semuelle commented Jun 6, 2024

No description provided.

@semuelle semuelle requested review from takahser and Noc2 June 6, 2024 14:44
@github-actions github-actions bot added the update docs PR to update the documentation of the grants program. Not a grant application. label Jun 6, 2024
Noc2
Noc2 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I also think it makes sense to remove the additional information in the readme, given that it looks pretty bad with the dark version of GitHub.

takahser
takahser requested changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably keep it consistent with the team name.
Appart from that, GJ, LGTM.

README.md Show resolved Hide resolved
docs/office-hours.md Show resolved Hide resolved
@semuelle semuelle merged commit cf593da into master Jun 7, 2024
9 checks passed
@semuelle semuelle deleted the office-hours branch June 7, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takahser takahser takahser requested changes

@Noc2 Noc2 Noc2 approved these changes

Assignees
No one assigned
Labels
update docs PR to update the documentation of the grants program. Not a grant application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@semuelle @takahser @Noc2