Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt ::aead to name change of NewAead to KeyInit #97

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Conversation

nc7s
Copy link
Contributor

@nc7s nc7s commented Oct 18, 2023

I'm interested in using schnorrkel derived keys as DH keys, but the ::aead module seems unfinished: can not compile, lacks documentation, etc.

A first commit adapts to the name change of NewAead to KeyInit in aead crate (#90), while I look forward to finishing the module along the line.

@nc7s nc7s changed the title Usable AEAD Usable AEAD/DH module Oct 18, 2023
@burdges
Copy link
Collaborator

burdges commented Oct 18, 2023

This is just an update of the aead module? okay cool.

We should ideally discuss if this module is in a good enough form, especially if folks want to use it with key derivation.

We should provide a noise feature & module which implements noise_protocol::DH trait probably, but..

Almost anyone using this wants one-off messages not handshakes I think, so that's not noise. I suppose derivation provides an interesting option here, but not sure soft derivations play nicely.

@nc7s nc7s changed the title Usable AEAD/DH module Aapt ::aead to name change of NewAead to KeyInit Oct 18, 2023
@nc7s
Copy link
Contributor Author

nc7s commented Oct 18, 2023

My intended use case would be that, with only a signing key of Alice, Bob can derive an encryption from it, while Alice can later derive the corresponding decryption key. Basically, to avoid a "standing" encryption key. There's no prolonged data exchange here, so it's indeed "one-off".

On a second thought, a PR isn't the best place to track something like this, and I'm no cryptographer either. Like, I don't really understand how Noise works, although it seems good to have.

@nc7s nc7s changed the title Aapt ::aead to name change of NewAead to KeyInit Adapt ::aead to name change of NewAead to KeyInit Oct 20, 2023
@burdges
Copy link
Collaborator

burdges commented Nov 8, 2023

Is this useful to you in its current state? I can try to figure out the failed CI, which may not be anything to do with you, and then go ahead and merge.. and other stuff can be another topic.

@nc7s
Copy link
Contributor Author

nc7s commented Nov 8, 2023

Just saw the failures so tried to fix them. Also this is just a normal PR to fix a few things, no need to change your course ;)

@burdges burdges merged commit c63cdef into w3f:master Nov 21, 2023
4 of 5 checks passed
@burdges
Copy link
Collaborator

burdges commented Nov 21, 2023

I fixed the CI and merged this. I'm not sure what AEAD functionality would be possible without getrandom, but maybe something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants