-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First half of work on expanding functionality to process external function generated event-data #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation range added
…re that only anwindices part of metashort is used
…hem to the end of daysummary
… only be used for acc value
…file name, updating documentation and minor fixes related to new bout functionality
…o first value of arg tseg #653
vincentvanhees
added a commit
that referenced
this pull request
Nov 22, 2024
ceil because machine precision can sometimes cause matrix() to create a value less than what we want, somehow I missed this in #1228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a preparation for addressing #653, which is about expanding GGIR's functionality to analyse and summarise event type of data produced by external functions. For example, steps, falls, scratches, or whatever events may be of interest to the GGIR user. I did most of this work two years ago as the research group for which I did the work needed time to properly test all functionality. They are happy now but still needs 3-6 months to finalise their work.
However, with their approval I am now merging the fundamental code changes because a lot of it has been complicating/slowing down the development of other parts of GGIR. So, technically there is no major functional enhancement yet for the user.
In summary:
g.getM5L5
in preparation for such a future merge but makes no functional changes in g.getM5L5.aggregateEvent
added to facilitate the aggregation of event type outcomes produced by external algorithms.check_myfun.R
expanded to facilitate new parameters specific to handling external function output.detectEventBouts.R
added to facilitate the detection of bouts in event-type behaviours such as steps.g.analyse.perday.R
to incorporate the more elaborate analyses of events produced by external functions.Next phase in a separate PR next year:
Checklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
file, if you think you made a significant contribution.