fix: extract file functionality #659
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Tested removing regex filter for extract functionality. Seems to have resolved this issue |
aj0413
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves broken feature introduced in #472
close #620
Tested to extract file from image and creates directory path starting from wherever dive was launched. Tested using README.md
Went ahead and figured out that the issue was in how the Image layer was being identified and passed down the stack.
Seems like the header.Name is the full 'blobs/sha256/[digest]' where as right now it just searches for an image named 'blobs'
NOTE: Further note that this only works when in the correct layer that adds/modifies the file
Tested with steps in issue, minimal dockerfile, and personal image. Used build on both MacOS (ARM) and Windows