Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor file service #159

Merged
merged 2 commits into from
Jun 21, 2024
Merged

refactor file service #159

merged 2 commits into from
Jun 21, 2024

Conversation

VictoriqueMoe
Copy link
Member

following changes:

  • Removed concept of soft delete, it will just straight up delete
  • Seperated the FileService to 2 services: FileUploadService (deals with only uploading files) and the FileService (deals with interacting with files, deleting them and retreval)

nakedmcse
nakedmcse previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@nakedmcse nakedmcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@VictoriqueMoe VictoriqueMoe merged commit 46d51df into main Jun 21, 2024
1 check passed
@VictoriqueMoe VictoriqueMoe deleted the refactor branch June 21, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakedmcse nakedmcse nakedmcse left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VictoriqueMoe @nakedmcse