#3200: Use OutputFilename instead of Name #3551
Conversation
WalkthroughThe recent updates improve clarity and accuracy in code, especially in error messages, during the MacOS build process. By utilizing fields from the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- v2/pkg/commands/build/packager.go (1 hunks)
Files skipped from review due to trivial changes (1)
- v2/pkg/commands/build/packager.go
|
Thanks 🙏 Please could you add an entry to the changelog located at |
|
What happens if you set your output filename in the Json to a blank string? |
|
Good question @leaanthony I noticed that we set it to name by default: |
|
LGTM. If you could just update the change log we'll look to get this in |
|
@leaanthony done, I put it under |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- website/src/pages/changelog.mdx (1 hunks)
Additional context used
LanguageTool
website/src/pages/changelog.mdx
[style] ~10-~10: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... existing functionality. -Deprecatedfor soon-to-be removed features. - `Removed...
[typographical] ~11-~11: Consider adding a comma here. (FOR_NOW_COMMA)
Context: ...oon-to-be removed features. -Removedfor now removed features. -Fixedfor any bug...
[style] ~12-~12: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...edfor now removed features. -Fixedfor any bug fixes. -Security` in case of ...
[duplication] ~17-~17: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ... vulnerabilities. ## [Unreleased] ### Fixed - Fixed MacOS build to useoutputfilenamefro...
[grammar] ~18-~18: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...es. ## [Unreleased] ### Fixed - Fixed MacOS build to useoutputfilenamefrom wail...
[duplication] ~22-~22: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...sues/3200) ## v2.9.1 - 2024-06-18 ### Fixed - Fixed build issues on Linux for some glibc ve...
[duplication] ~27-~27: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...eaanthony. ## v2.9.0 - 2024-06-16 ### Added - Added Drag & Drop (files or folders) support ...
[grammar] ~43-~43: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...etPosition` values were inconsistent on MacOS. Fixed by [@cenan](https://github.com/w...
[duplication] ~52-~52: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...b.com//issues/3421). ### Added - Added support for proxying assets requests to...
[duplication] ~55-~55: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...thub.com//pull/3463) ### Fixed - Fixed an issue with missing icon for Windows....
[style] ~62-~62: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...u can choose between vscode and goland. Added by @DiegPS in [PR](https://github.com/w...
[style] ~69-~69: Consider using a different verb for a more formal wording. (FIX_RESOLVE)
Context: .../pull/3289) ### Fixed - Fixed an issue where embed directives with pa...
[style] ~77-~77: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...the default name to the project’s name. Changed by [@Twacqwq](https://github.com/Twacqw...
[style] ~83-~83: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...portsDisablePinchZoomconfiguration. Added by @tuuzed in [PR](https://github.com/w...
[duplication] ~90-~90: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...thub.com//pull/3157) ### Fixed - Fixed vue-ts template build error. Fixed by @...
[uncategorized] ~96-~96: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA)
Context: ...ails/pull/3154)). - Fixed React Routing documentation add 'Routes' and 'Route'. Fixed by @dOr...
[uncategorized] ~157-~157: “its” (belonging to it) seems less likely than “it’s” (it is) (AI_HYDRA_LEO_CPT_ITS_ITIS)
Context: ...tion and wrong initial window size when its enabled. Added by @lyimmi in [PR](https...
[uncategorized] ~159-~159: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...Fixed filesystem watcher from filtering top level project directory if binary name is inc...
[uncategorized] ~165-~165: The official spelling of this programming framework is “Node.js”. (NODE_JS)
Context: .../pull/2876) ### Added - Added correct NodeJS and Docker package names for DNF packag...
[style] ~165-~165: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...s for DNF package manager of Fedora 38. Added by @aranggitoar in [PR](https://github....
[style] ~170-~170: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... frontend. - Added sveltekit.mdx guide. Added by @figuerom16 in [PR](https://github.c...
[style] ~195-~195: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ring fast reloads of requests on macOS. Fixed by @stffabi in [PR](https://github.com/...
[uncategorized] ~207-~207: The official spelling of this programming framework is “Node.js”. (NODE_JS)
Context: ...pp/wails/pull/2610) ### Added - Added Nodejs version inwails doctor. Added by @mi...
[style] ~207-~207: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...Added Nodejs version inwails doctor. Added by @misitebao in [PR](https://github.co...
[grammar] ~208-~208: The singular determiner ‘this’ may not agree with the plural noun ‘features’. Did you mean “these”? (THIS_NNS)
Context: ...agwebkit2_40to activate support for this features. This also bumps the minimum r...
[uncategorized] ~209-~209: If this is a compound adjective that modifies the following noun, use a hyphen. (EN_COMPOUND_ADJECTIVE_INTERNAL)
Context: ...2) - macOS: Added Window menu role with well known shortcuts "Minimize, Full-Screen and Zo...
[style] ~220-~220: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ... printing inwails generate template. Fixed by @misitebao in [PR](https://github.co...
[style] ~237-~237: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...AssetServer tried to log to the logger. Fixed by @stffabi in [PR](https://github.com/...
[style] ~244-~244: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...cs/reference/options#webviewgpupolicy). Added by @lyimmi in [PR](https://github.com/w...
[grammar] ~245-~245: The word “opt-in” is a noun. The verb is spelled with a white space. (NOUN_VERB_CONFUSION)
Context: ...leFraudulentWebsiteDetection` option to opt-in to scan services for fraudulent content...
[style] ~253-~253: This phrase is redundant. Consider using “outside”. (OUTSIDE_OF)
Context: ...therwise resizing cursor won't be shown outside of the body rectangle. Changed by @stffabi...
[style] ~259-~259: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...ild hooks whenbuild/binwas missing. Fixed by @lyimmi in [PR](https://github.com/w...
[grammar] ~266-~266: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...m//pull/2397) - Fixed the macos single architecture builds not respecti...
[style] ~276-~276: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. (ENGLISH_WORD_REPEAT_BEGINNING_RULE)
Context: ...artup of the application in debug mode. Added by @stffabi in [PR](https://github.com/...
[grammar] ~282-~282: The singular determiner ‘this’ may not agree with the plural noun ‘features’. Did you mean “these”? (THIS_NNS)
Context: ...agwebkit2_36to activate support for this features. This also bumps the minimum r...
[grammar] ~399-~399: It appears that an article is missing. (IN_WEBSITE)
Context: ...pp/wails/pull/1965 - Use swc + pnpm for website - @leaanthony in https://github.com/wai...
[grammar] ~456-~456: It appears that an article is missing. (IN_WEBSITE)
Context: ...sapp/wails/pull/1795 - fix: fix bugs in website by @misitebao in https://github.com/wai...
[typographical] ~496-~496: Use a comma after an introductory phrase. (COMMA_INTRODUCTORY_WORDS_PHRASES)
Context: ...o-drag"` to disable the drag behaviour. For this release only, you can test this by sett...
[grammar] ~546-~546: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...pp/wails/pull/1662 - Multiple fixes for MacOS asset requests by @stffabi in https://g...
[grammar] ~551-~551: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...ub.com//pull/1704 - Allow MacOS frameless window to be miniturisable by...
[grammar] ~556-~556: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...1671 - wails doctor now reports correct MacOS os id by @stffabi in https://github.com...
[grammar] ~577-~577: Before the countable noun ‘of’ an article or a possessive pronoun is necessary. (IN_NN_CC_VBG)
Context: ...ny ### Fixed - Fixed initial build of frontend when usingwails devon new projects ...
[uncategorized] ~588-~588: Did you mean “too”? (TOO_JJ_TO)
Context: ...-24 ### Added - Add Show() and Hide() to runtime to show/hide application by @le...
[grammar] ~640-~640: The correct preposition appears to be “on”. (IN_WINDOWS)
Context: ...1555 ### Fixed - Fix stack corruption in Windows when using ICoreWebView2HttpHea...
[grammar] ~753-~753: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...thub.com//pull/1414 - Add macos custom menu EditMenu tips by @daodao97 ...
[grammar] ~816-~816: This expression is usually spelled with a hyphen. (DOUBLE_CLICK_HYPHEN)
Context: ... @napalu - Double Click event now works on elements with `data-...
[grammar] ~838-~838: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...](https://github.com/napalu) in #1249 - MacOS - Show extension by default by [@leaant...
[misspelling] ~842-~842: This word is normally spelled with a hyphen. (EN_COMPOUNDS_CROSS_PLATFORM)
Context: ...tor works only for some directives in a cross platform way by [@stffabi](https://github.com/...
[grammar] ~845-~845: It appears that an article is missing. (IN_WEBSITE)
Context: ...adalessa) in #123 - Use local search on website by [@leaanthony](https://github.com/lea...
[misspelling] ~853-~853: This word is normally spelled with a hyphen. (EN_COMPOUNDS_SELF_STARTING)
Context: ...ilt) in #1247 - [v2] Use os.Args[0] for self starting wails by [@stffabi](https://github.com/...
Additional comments not posted (1)
website/src/pages/changelog.mdx (1)
17-19: The changelog entry under "Unreleased" correctly documents the macOS build configuration change to useoutputfilenamefromwails.json. However, consider expanding this entry to include information about how this change impacts macOS builds, especially any potential differences in behavior or compatibility issues that users should be aware of.Tools
LanguageTool
[duplication] ~17-~17: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ... vulnerabilities. ## [Unreleased] ### Fixed - Fixed MacOS build to useoutputfilenamefro...
[grammar] ~18-~18: The operating system from Apple is written “macOS”. (MAC_OS)
Context: ...es. ## [Unreleased] ### Fixed - Fixed MacOS build to useoutputfilenamefrom wail...
|
|
I suspect this might be a breaking change for some people 🤔 |
Issue: #3200
Solution: use
options.ProjectData.OutputFilenameinstead ofoptions.ProjectData.NameSummary by CodeRabbit
Bug Fixes
outputfilenamefromwails.json.Documentation