Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bootstrap to version 5 #158

Merged
merged 9 commits into from
Jan 15, 2024
Merged

update bootstrap to version 5 #158

merged 9 commits into from
Jan 15, 2024

Conversation

jvelezpo
Copy link
Contributor

@jvelezpo jvelezpo commented Jan 18, 2023

Summary

  • Updates bootstrap to latest version v5
  • Uses sass as css pre-processor instead of less which is default on bootstrap v5
Screen.Cast.2024-01-10.at.3.29.45.PM.mp4

@alanhamlett alanhamlett marked this pull request as ready for review January 18, 2023 11:07
@alanhamlett alanhamlett marked this pull request as draft January 18, 2023 11:07
@jvelezpo jvelezpo marked this pull request as ready for review January 10, 2024 20:30
Copy link
Member

@gandarez gandarez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's squash and merge to remove merge commits.

@jvelezpo jvelezpo changed the title chore: update bootstrap to version 5 update bootstrap to version 5 Jan 11, 2024
@jvelezpo
Copy link
Contributor Author

@alanhamlett Can you please check the video in the Description and let me know if you fine this ok to land in prod 👍

@alanhamlett
Copy link
Member

👍

@jvelezpo jvelezpo merged commit 3406e1c into master Jan 15, 2024
1 check passed
@jvelezpo jvelezpo deleted the sebas-update-bootstrap branch January 15, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants