Upgrade @miniben90/x-win to lower glibc dependency #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, but to merge this we need the branch name matching one of these patterns: https://github.com/wakatime/desktop-wakatime/blob/main/CONTRIBUTING.md#branches |
|
Why do you care what's the branch name on my fork which i remove instantly after you merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix the issue #91 by upgrading the @miniben90/x-win package to version 2.1.0.
The current version (
1.10.2) requires GLIBC 2.33, which is unavailable on many older Linux distributions, including Ubuntu 20.04. According to the release notes, version2.0.0of @miniben90/x-win reduces this requirement to GLIBC 2.18, making the app compatible with a wider range of platforms.Since this involves a major version bump, I reviewed the changelog and tested the application for any incompatibilities. I found no breaking changes, and the application functions as expected after the upgrade.