Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review bundler #579

Open
D4nte opened this issue Feb 25, 2022 · 4 comments
Open

Review bundler #579

D4nte opened this issue Feb 25, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers infra Infra, devops, CI and related tasks

Comments

@D4nte
Copy link
Contributor

D4nte commented Feb 25, 2022

Problem

  1. We use rollup for production bundling but use webpack to bundle for karma
  2. We use tsc for code transpilation, other tools such as parcel and vite provide faster result (and vite includes rollup and claim to make the configuration easier).

Goal

Simplify the configuration by using a single bundler across the project (1).
Check if more modern/upcoming solutions helps streamline the process (ie, parcel, vite vs tsc).

Proposed solutions

a. Review how karma can work with vilte or rollup
b. Check if parcel, vite or esbuild can be used instead of tsc and what would be the gains
c. Review what aegir (used by libp2p) can bring in.

Notes

status-im/status-web#227 (comment)

@D4nte D4nte changed the title Migrate from webpack to rollup Consider rollup + parcel Feb 28, 2022
@D4nte
Copy link
Contributor Author

D4nte commented May 20, 2022

Draft parcel PR: #747

@fryorcraken fryorcraken changed the title Consider rollup + parcel Review bundler Aug 26, 2022
@fryorcraken fryorcraken added infra Infra, devops, CI and related tasks track:maintenance good first issue Good for newcomers labels Aug 26, 2022
@fryorcraken
Copy link
Collaborator

Marked as good first issue because it does not involve knowledge of js-waku codebase, just knowledge of bundler and transpiler and other ci/build/test tools.

@fryorcraken
Copy link
Collaborator

Should be done with #1008 in mind

@fryorcraken
Copy link
Collaborator

Other problems:

  • Bundle sizes are big (few MB)
  • size limit only give data for projects using a bundler, projects using esm directly in script tag get much bigger package,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers infra Infra, devops, CI and related tasks
Projects
Status: To Do
Development

Successfully merging a pull request may close this issue.

3 participants