Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parcel for main and esm builds #747

Closed
wants to merge 4 commits into from
Closed

Use parcel for main and esm builds #747

wants to merge 4 commits into from

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented May 18, 2022

Resolves #579

@github-actions
Copy link

github-actions bot commented May 18, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
build/esm/index.js 1.57 MB (+0.03% 🔺) 32.3 s (+0.03% 🔺) 1.7 s (+18.59% 🔺) 34 s

@D4nte
Copy link
Contributor Author

D4nte commented May 18, 2022

Published to @waku/staging.
Looks good in React app.

However, with NodeJS, getting:

import {discovery} from "@waku/staging";
        ^^^^^^^^^
SyntaxError: Named export 'discovery' not found. The requested module '@waku/staging' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@waku/staging';
const {discovery} = pkg;

Ideally I'd like to enable user to use the import { foo } from "js-waku" syntax.

No luck so far in finding how to make parcel bundle it as it was done with tsc.

@prichodko, is that something you are familiar with?

@D4nte D4nte mentioned this pull request May 20, 2022
@D4nte
Copy link
Contributor Author

D4nte commented Jul 27, 2022

To be tried again once #803 is merged

@D4nte D4nte closed this Jul 27, 2022
@fryorcraken fryorcraken deleted the parcel branch September 26, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review bundler
1 participant