fix: bumping nim-secp256k1 lib to latest version...

[NagyZoltanPeter]

...that fixes AMD compilation bug in upstream library bitcoin-core/secp256k1

Description

Fixes: #2560

Changes

• latest nim-secp256k1 library elevates upstream project bitcoin-core/secp256k1 that fixes lack of support for latest AMD processors with GCC.

Further information: status-im/nim-secp256k1#56 -> status-im/nim-secp256k1#58

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2882

Built from 311eab1

[gabrielmer]

Thank you!

[SionoiS]

I tested this branch ans it fail to compile with the same error as before.

[gabrielmer]

I tested this branch ans it fail to compile with the same error as before.

Did you run make update?

[SionoiS]

Did you run make update?

yes of course, I even did a clean clone of nwaku repo just to be sure...

[NagyZoltanPeter]

Did you run make update?

yes of course, I even did a clean clone of nwaku repo just to be sure...

Thanks for checking... Not good... Will check later.

[NagyZoltanPeter]

Did you run make update?

yes of course, I even did a clean clone of nwaku repo just to be sure...

Thanks for checking... Not good... Will check later.

@SionoiS can U please paste here the build log?

[SionoiS]

                 from /home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1/src/secp256k1.c:28:
/home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1/src/scalar_4x64_impl.h: In function ‘secp256k1_scalar_reduce_512’:
/home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1/src/scalar_4x64_impl.h:361:5: error: ‘asm’ operand has impossible constraints
  361 |     __asm__ __volatile__(
      |     ^~~~~~~
/home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1/src/scalar_4x64_impl.h:475:5: error: ‘asm’ operand has impossible constraints
  475 |     __asm__ __volatile__(
      |     ^~~~~~~
Error: execution of an external compiler program 'gcc -c  -w -fmax-errors=3 -pthread -I"/home/sionois/Github/nwaku/vendor/nim-libbacktrace" -I"/home/sionois/Github/nwaku/vendor/nim-libbacktrace/install/usr/include" -I/home/sionois/Github/nwaku/vendor/nim-bearssl/bearssl/abi -I/home/sionois/Github/nwaku/vendor/nim-bearssl/bearssl/abi/../csources/src/ -I/home/sionois/Github/nwaku/vendor/nim-bearssl/bearssl/abi/../csources/inc/ -I/home/sionois/Github/nwaku/vendor/nim-bearssl/bearssl/abi/../csources/tools/ -DBR_USE_UNIX_TIME=1 -DBR_USE_URANDOM=1 -DBR_LE_UNALIGNED=1 -DBR_64=1  -DBR_amd64=1 -DBR_INT128=1 -I/home/sionois/Github/nwaku/vendor/nim-zlib/zlib/csources -DHAVE_UNISTD_H -I/home/sionois/Github/nwaku/vendor/nim-nat-traversal/vendor/miniupnp/miniupnpc/include -I/home/sionois/Github/nwaku/vendor/nim-nat-traversal/vendor/libnatpmp-upstream -DENABLE_STRNATPMPERR -march=native -g3 -Og -O3 -fno-strict-aliasing -fno-ident  -DENABLE_MODULE_ECDH=1 -DENABLE_MODULE_RECOVERY=1 -DENABLE_MODULE_SCHNORRSIG=1 -DENABLE_MODULE_EXTRAKEYS=1 -I/home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1 -I/home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1/src -DUSE_ASM_X86_64  -I/home/sionois/Github/nwaku/vendor/nimbus-build-system/vendor/Nim/lib -I/home/sionois/Github/nwaku/apps/wakunode2 -o nimcache/release/wakunode2/@m..@s..@svendor@snim-secp256k1@svendor@ssecp256k1@[email protected] /home/sionois/Github/nwaku/vendor/nim-secp256k1/secp256k1/../vendor/secp256k1/src/secp256k1.c' failed with exit code: 1


stack trace: (most recent call last)
/home/sionois/Github/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(429, 18)
/home/sionois/Github/nwaku/waku.nimble(77, 15) wakunode2Task
/home/sionois/Github/nwaku/waku.nimble(35, 8) buildBinary
/home/sionois/Github/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(273, 7) exec
/home/sionois/Github/nwaku/vendor/nimbus-build-system/vendor/Nim/lib/system/nimscript.nim(273, 7) Error: unhandled exception: FAILED: nim c --out:build/wakunode2  --verbosity:0 --hints:off -d:chronicles_log_level=TRACE -d:git_version="v0.30.1-32-gf02f77" -d:release --passL:librln_v0.5.1.a --passL:-lm apps/wakunode2/wakunode2.nim [OSError]
make: *** [Makefile:190: wakunode2] Error 1```