Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: libwaku better params validation and a bit more clarity #3005

Merged
merged 1 commit into from
Aug 29, 2024
Merged

chore: libwaku better params validation and a bit more clarity #3005

merged 1 commit into from
Aug 29, 2024

Conversation

Ivansete-status
Copy link
Collaborator

Description

This PR enhances libwaku and is inspired by SP's comment: #3003 (comment)

Changes

  • Add negentropy reference in cwaku_examples
  • New checkLibwakuParams in libwaku.nim
  • Rename Context to WakuContext to make it a little bit more explicit
  • Remove callback from library/waku_thread/inter_thread_communication/requests/protocols/store_request.nim because not needed.

@Ivansete-status Ivansete-status marked this pull request as ready for review August 29, 2024 15:53
@github-actions GitHub Actions
Copy link

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3005

Built from 6ee00d6

@Ivansete-status Ivansete-status changed the title chore: libwaky better params validation and a bit more clarity chore: libwaku better params validation and a bit more clarity Aug 29, 2024
gabrielmer
gabrielmer approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Thanks you! 😍

SionoiS
SionoiS approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@SionoiS SionoiS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@Ivansete-status Ivansete-status merged commit 19feb6b into master Aug 29, 2024
12 of 14 checks passed
@Ivansete-status Ivansete-status deleted the better-callback-check branch August 29, 2024 20:57
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SionoiS SionoiS SionoiS approved these changes

@gabrielmer gabrielmer gabrielmer approved these changes

@darshankabariya darshankabariya Awaiting requested review from darshankabariya

Assignees

@Ivansete-status Ivansete-status

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ivansete-status @SionoiS @gabrielmer