Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

android-safetynet #24

Open
tnokin opened this issue Jan 4, 2020 · 2 comments · May be fixed by #26
Open

android-safetynet #24

tnokin opened this issue Jan 4, 2020 · 2 comments · May be fixed by #26

Comments

@tnokin
Copy link

tnokin commented Jan 4, 2020

I used this lib to implement a fingerprint login on Android+Chrome. But then I received "android-safetynet" value in server/src/registration.js, where there is only "fido-u2f" and "packed" supported. So I forked and added the the option (but I'm no expert). Might be useful to others.

What I don't understand is why no one else had the issue ? Did I do smthg wrong on the client ?

Also I can't get this to work on Chrome on Windows. More exactly the fingerprint options is not proposed, only the security key. I feel this is more related to Windows than to the lib but I'd like to hear if someone has succeded using this on Windows ?
@Kmaschta
Copy link
Contributor

Kmaschta commented Jan 6, 2020

Hi @tnokin,

This library was released to fulfill the needs of an authentication with a FIDO2 key only.
All other authentication methods weren't implemented. See the roadmap at the end of the README:

image

To my knowledge, it is not planned to implement the support of the other authentication methods any time soon.
But this repository is open-source, feel free to contribute!

@eheikes eheikes linked a pull request Jan 16, 2020 that will close this issue
Open
@eheikes
Copy link
Contributor

eheikes commented Jan 16, 2020

@tnokin Take a look at PR #26 and see what you think... I took some code from your fork and incorporated it with my code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for Android SafetyNet Banno/webauthn
3 participants
@eheikes @Kmaschta @tnokin