Add support for Android SafetyNet #26
Open
+240
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR adds support for the
android-safetynet
attestation format to theserver
package. It should close #24.Details
parseAndroidSafetyNetKey()
follows the process outlined in the WebAuthn specs and the SafetyNet docs.validateAndroidSafetyNetKey()
andparseAttestationData()
basically duplicates the code from the other formats, since it's the same routine for all.The original implementation in our fork has been tested and will be used in production soon. This PR takes code & ideas from @tnokin's fork to improve upon the original code.
How To Test
You can test against a real-world example:
Running this should result in: