concord-server: option to look up GH webhook event sender by email #1243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off #1242, since it requires authentication tokens for one or more GitHub instances. Will rebase after that's merged and this will be a much smaller change.
Github triggers'
useInitiatoroption requires some info to cross-reference back to the LDAP source of truth. Enterprises using GitHub.com with their own SSO provider may won't have a directldap_dnattribute, or a guaranteed-to-match username for webhook senders. The sender's email address in the webhook payload either.This change adds an option (disabled by default) to correlate webhook senders to their LDAP principal info so the Concord process can run as the appropriate user. This takes to steps:
email