Adds a clarification around artifact types. #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noaleetz
reviewed
May 22, 2024
noaleetz
reviewed
May 22, 2024
noaleetz
reviewed
May 22, 2024
noaleetz
reviewed
May 23, 2024
There was a problem hiding this comment.
I think it could be helpful to explicitly connect the image with the code snippet and show the relationship in a diagram. I attached a sketch I made, maybe it's worth getting a more official version with Raven's help?
There was a problem hiding this comment.
@noaleetz I have updated this PR for Hugo but using the exact same image and text that Kathryn came up with previously. Do you still think that an image similar to this one is better?
There was a problem hiding this comment.
Hey! Yes - I think sharing an image that demonstrates:
- how type is defined in an artifact
- how that will be represented in lineage
is important, as we've had users ask how this field is set, and what it impacts in the artifact UI
noaleetz
requested changes
May 23, 2024
Deploying docodile with
|
| Latest commit: |
13f6fb1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb0d4bb6.docodile.pages.dev |
| Branch Preview URL: | https://artifacts-landing.docodile.pages.dev |
johndmulhausen
approved these changes
Oct 3, 2024
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 45.3%, saving 130.03 KB.
409 images did not require optimisation. |
Summary
|
mdlinville
force-pushed
the
artifacts-landing
branch
from
13f6fb1 to
8b20a01
Compare
Deploying docs with
|
| Latest commit: |
8b20a01
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://30361155.docodile.pages.dev |
| Branch Preview URL: | https://artifacts-landing.docodile.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a clarification around artifact types based on customer feedback.
Ticket
Does this PR fix an existing issue? If yes, provide a link to the ticket here:
Checklist
Check if your PR fulfills the following requirements. Put an
Xin the boxes that apply.yarn start. My changes did not break the local preview.yarn docusaurus build) was run locally and successfully without errors or warnings.maininto my feature branch before submitting this PR.