-
Notifications
You must be signed in to change notification settings - Fork 733
fix: resuming a run would overwrite image masks #9592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9592 +/- ##
==========================================
+ Coverage 80.43% 80.45% +0.01%
==========================================
Files 741 741
Lines 78840 78847 +7
==========================================
+ Hits 63418 63438 +20
+ Misses 14692 14676 -16
- Partials 730 733 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
3ae4dc6
to
9c2347e
Compare
9c2347e
to
7f4d61a
Compare
00b7428
to
8f1e630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution LGTM, just some suggestions for writing a more maintainable test.
fix legacy which would unset keys during resume run
Co-authored-by: Timofey Peshin <[email protected]>
03b8565
to
65c51bf
Compare
Description
What does the PR do? Include a concise description of the PR contents.
When resuming a run, the image mask is not carried over to the new run config. This causes the original image to lose any image masks which it had.
This change adds
masks/class_labels
config key as one of the keys which should be copied over during run resume.Testing
How was this PR tested?