Skip to content

fix: resuming a run would overwrite image masks #9592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 21, 2025
Merged

Conversation

jacobromero
Copy link
Contributor

@jacobromero jacobromero commented Mar 18, 2025

Description

What does the PR do? Include a concise description of the PR contents.

When resuming a run, the image mask is not carried over to the new run config. This causes the original image to lose any image masks which it had.
This change adds masks/class_labels config key as one of the keys which should be copied over during run resume.

  • I updated CHANGELOG.unreleased.md, or it's not applicable

Testing

How was this PR tested?

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (2bef6be) to head (65c51bf).
Report is 87 commits behind head on main.

Files with missing lines Patch % Lines
wandb/sdk/internal/sender_config.py 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #9592      +/-   ##
==========================================
+ Coverage   80.43%   80.45%   +0.01%     
==========================================
  Files         741      741              
  Lines       78840    78847       +7     
==========================================
+ Hits        63418    63438      +20     
+ Misses      14692    14676      -16     
- Partials      730      733       +3     
Flag Coverage Δ
func 46.03% <75.00%> (-0.03%) ⬇️
system 64.94% <91.30%> (+0.12%) ⬆️
unit 65.30% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/internal/runconfig/runconfig.go 93.20% <100.00%> (+1.46%) ⬆️
tests/system_tests/test_core/test_resume.py 100.00% <100.00%> (ø)
wandb/sdk/wandb_run.py 88.85% <ø> (+0.09%) ⬆️
wandb/sdk/internal/sender_config.py 76.31% <0.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobromero jacobromero requested review from timoffex and removed request for timoffex March 18, 2025 23:41
@jacobromero jacobromero marked this pull request as ready for review March 19, 2025 20:48
@jacobromero jacobromero requested a review from a team as a code owner March 19, 2025 20:48
@jacobromero jacobromero force-pushed the resumemaskfix branch 2 times, most recently from 00b7428 to 8f1e630 Compare March 19, 2025 22:54
Copy link
Contributor

@timoffex timoffex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution LGTM, just some suggestions for writing a more maintainable test.

@jacobromero jacobromero merged commit c924c4e into main Mar 21, 2025
34 of 35 checks passed
@jacobromero jacobromero deleted the resumemaskfix branch March 21, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[App]: Initially logged image segmentation masks disappear after experiment is being resumed
2 participants