Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(weave): Swap to codegen server bindings #3870

Open
wants to merge 6 commits into
base: andrew/codegen2
Choose a base branch
from
Open

chore(weave): Swap to codegen server bindings #3870

wants to merge 6 commits into from

Conversation

andrewtruong
Copy link
Collaborator

@andrewtruong andrewtruong commented Mar 10, 2025 •
edited
Loading

This PR swaps in the Stainless generated bindings into RemoteHTTPTraceServer

@andrewtruong andrewtruong changed the base branch from master to andrew/codegen2 March 10, 2025 18:25
@circle-job-mirror
Copy link

circle-job-mirror bot commented Mar 10, 2025 •
edited
Loading

Preview this PR with FeatureBee: https://beta.wandb.ai/?betaVersion=25ca5c52a6c23b488f59caee74ef5f5665b39f5d

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2025

Caution

Review failed

The head commit changed during the review from 16b3170 to 543187c.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 16, 2025 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@andrewtruong andrewtruong marked this pull request as ready for review March 17, 2025 14:13
@andrewtruong andrewtruong requested a review from a team as a code owner March 17, 2025 14:13
tssweeney
tssweeney reviewed Mar 18, 2025
View reviewed changes
weave/trace_server_bindings/remote_http_trace_server.py
self.remote_request_bytes_limit = remote_request_bytes_limit

self.stainless_client = WeaveTrace(
username=entity_name if entity_name else "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't understand why you are passing entity name around. It should always be blank

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will default to weave_wandb_entity_name() if missing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but why is it needed? it is not used in auth

tssweeney
tssweeney reviewed Mar 18, 2025
View reviewed changes
tests/trace_server/test_remote_http_trace_server.py Outdated
@@ -1,127 +0,0 @@
import datetime
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not longer want to test error code handling?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this got deleted; undeleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tssweeney tssweeney tssweeney left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewtruong @tssweeney