Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): Custom providers drawer design update #3892

Open
wants to merge 18 commits into
base: custom-providers-pg
Choose a base branch
from

Conversation

m-rgba
Copy link
Contributor

@m-rgba m-rgba commented Mar 18, 2025

Description

Design update for custom AI provider drawer.
Updated from master to get updates to the resizeablesidebar component - this was the only meaningful change:
https://github.com/wandb/weave/pull/3892/files#diff-a535af1cfe19d3df5dddc4a1fa596ee756124e9e8caad8dae3b6887b734f1aa0

Before After
CleanShot 2025-03-18 at 13 24 21 CleanShot 2025-03-18 at 13 25 07
  • Updated header area for height and font weight.
  • Updated font to use Source Sans Pro / made typography feel right.
  • Updated spacing between form elements.
  • Made some tweaks to padding and sizing to prevent page overflow when the screen is short.
  • Updated padding around the form.
  • Adjusted button sizes on the clear buttons to match the inline inputs.
  • Added a sample endpoint description to the base URL field.
  • Made buttons full width - added submit / edit logic to the text.

Functional changes:

  • Used the ResizeablDrawer cause we should probably center around using those for most of these non-peek drawers.
  • Added default header and model rows to save on an action for adding a new row.
  • Stripped empty headers (similar to the stripping model logic).
  • Stripped the trailing / for the baseURL onSubmit (cause I do that all the time other places when I'm setting up custom models and it's annoying to debug).

@m-rgba m-rgba changed the title Custom providers design update Custom providers drawer design update Mar 18, 2025
Copy link
Contributor

github-actions bot commented Mar 18, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@m-rgba m-rgba changed the title Custom providers drawer design update chore(ui): Custom providers drawer design update Mar 18, 2025
@m-rgba m-rgba marked this pull request as ready for review March 18, 2025 17:28
@m-rgba m-rgba requested review from a team as code owners March 18, 2025 17:28
</Typography>
<TextField
placeholder="Enter API key name"
placeholder="Enter API key / token..."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im worried this might be confusing,
i used name because putting the token itself here doesnt work
you have to put the name and then add the name and token to the team secrets

@neutralino1
Copy link
Contributor

Maybe your target branch needs to be rebased to master as well. It seems the PR diff is showing many unrelated changes, which makes it hard to review atomically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants