-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert impeller #102
revert impeller #102
Conversation
I wonder if we can detect whether impeller is enabled or not in java or dart. If impeller is enabled, use SurfaceProducer, otherwise use SurfaceTextureEntry. |
i like that idea, but it needs some research to find the flag they use, if i was able to find it will update the pr |
no, it returns different SurfaceProducer depending on system version. I think we can check 'io.flutter.embedding.android.EnableImpeller' in AndroidManifest.xml like this https://github.com/flutter/engine/blob/3.23.0-12.0.pre/shell/platform/android/io/flutter/embedding/engine/loader/FlutterLoader.java#L343 But i'm not sure the difference between <meta-data
android:name="io.flutter.embedding.android.EnableImpeller"
android:value="true" /> |
i can detect impeller from androidmanifest.xml: master...impeller I'm using flutter 3.22, video is blank if i enable impeller in xml, iirc flutter 3.19 impeller works correctly, can you test it? |
i am still facing the crash problem, i guess its related to impller being enabled, not a problem from your side, also in your code you dont detect if the user launched with |
i tried video_player example without fvp and got no crash, with impller on and off, but fvp example crashes.
i am testing on this master...impeller |
can you share your example code or apk? |
I guess so |
i can share the apk since its fvp example, do you know how to extract the crash logs? just for general debugging |
https://easyupload.io/n96qnu is the apk |
Then run |
this where i was lost on how to debug |
You mdk is too old, please upgrade to the latest nightly build version. It crash in flutter, so can't see line number
|
i did run flutter clean and flutter pub clean, how can i delete the old version, should the code auto delete the version and get new one to avoid this kind of problems? instead of deleting cache i mean |
I also have a problem in logging, iirc the logging package used in fvp can print log to logcat, but now I can't see any fvp log recently |
in my apk, i didnt add the logging , or you mean internally it should show? |
okay since i was testing locally flutter clean and pub cache where not deleting the mdk files, so i deleted them manually, but do you think in cmake an mdk version check can be added? and download new version if the one found is not the latest? for easier debugging and to avoid this problem with other people too i think thats the safest option |
i can confirm now that master...impeller is working correctly , with impller on, it does lead to black screen when closing screen and reopen it, and with impller off it works even after closing screen and bringing it on. |
I add logging and tested yesterday.
Maybe a fixed version is better. An ideal solution is pass an additional option to |
Thanks for testing. What's your flutter version? Mine is 3.22, impeller shows nothing. When I tested with 3.19 before, i can see video. |
let me know your plan and i can help update the cmakes to do it, maybe an env variable can help |
i am using |
env is also a good idea.
ok, so that branch is better than no impeller support. I'm going to close this pr and merge that branch |
should fix #101