win: system menu: fix separator can't be removed

wangwenx190 · Oct 20, 2023 · c7f4868 · c7f4868
1 parent 4821e89
commit c7f4868
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/core/utils_win.cpp b/src/core/utils_win.cpp
@@ -1341,7 +1341,8 @@ bool Utils::showSystemMenu(const WId windowId, const QPoint &pos, const bool sel
         ::EnableMenuItem(hMenu, SC_CLOSE, (MF_BYCOMMAND | (disableClose ? MFS_DISABLED : MFS_ENABLED)));
     }
     if (removeSeparator) {
-        if (::DeleteMenu(hMenu, SC_SEPARATOR, MF_BYCOMMAND) == FALSE) {
+        // Looks like we must use 0 for the second parameter here, otherwise we can't remove the separator.
+        if (::DeleteMenu(hMenu, 0, MFT_SEPARATOR) == FALSE) {
             //WARNING << getSystemErrorMessage(kDeleteMenu);
         }
     }