-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generate exception if codec/layer versions or channel headers are unrecognized #36
base: master
Are you sure you want to change the base?
Conversation
This is not sufficient, we need to consider
|
@joshtrichards mind to update your pr with jeremitu's suggestion? I will patch the copy in nextcloud/3rdparty then. |
Done. Rather than add a check for it, I dropped CODEC_UNDEFINED outright in the parser. It's "documented" only as reserved from all the mp3 header docs I can find online, including the one referenced from this repo @ http://mpgedit.org/mpgedit/mpeg_format/mpeghdr.htm It got added as part of the fix for #14, but that was for MPEG_25 and I think CODEC_UNDEFINED just got tossed in there for completeness at the time. We're not bothering to parse the the "reserved" ones elsewhere (e.g. for the |
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]> [skip ci]
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]> [skip ci]
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Patch: wapmorgan/Mp3Info#36 Signed-off-by: Daniel Kesselberg <[email protected]>
Thanks (once again) for the useful library we use over at the Nextcloud project!
While looking into nextcloud/server#44573, I noted we might as well throw an informative exception if the
codecVersion
,layerVersion
, orchannel
headers are unrecognized.We're going to error out anyway when we try to use empty values for the array key. Instead of generating generic PHP errors when we go to set the
bitRate
andsampleRate
orvbr_offset
we can leave the user a bit less confused about the underlying cause.I don't even know what MP3s might cause this, but seems reasonable to handle this situation cleanly if possible. :)